ScreenWithCallback for tabs navigators#34
Merged
MoOx merged 1 commit intorescript-react-native:masterfrom Jul 8, 2020
Merged
Conversation
MoOx
approved these changes
Jul 8, 2020
Member
MoOx
left a comment
MoOx
left a comment
There was a problem hiding this comment.
Looks good, but can you have a look to my comment?
| React.component({ | ||
| . | ||
| "navigation": navigation, | ||
| "route": route, |
Member
There was a problem hiding this comment.
Can this be declared as a standard record?
Member
Author
There was a problem hiding this comment.
I don't know, I copied the way it was done on the Stack 😅
https://github.com/reason-react-native/reason-react-navigation/blob/a7d40f04e6785ed0c4525ad2b5f63a287282cf7f/src/Stack.re#L127
https://github.com/reason-react-native/reason-react-navigation/blob/a7d40f04e6785ed0c4525ad2b5f63a287282cf7f/src/Stack.re#L269-L282
Member
There was a problem hiding this comment.
Ok so we could change that later in all places
| React.component({ | ||
| . | ||
| "navigation": navigation, | ||
| "route": route, |
Member
There was a problem hiding this comment.
Same question here (not sure it's doable for some reason)
Member
Author
|
Thank you! 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScreenWithCallback for BottomTabs, MaterialBottomTabs and MaterialTopTabs navigators, to match the Stack navigator.