Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings during compilation #5

Open
hoichi opened this issue Jan 29, 2019 · 3 comments
Open

Warnings during compilation #5

hoichi opened this issue Jan 29, 2019 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@hoichi
Copy link

hoichi commented Jan 29, 2019

Hi! Don’t know if anyone noticed 😁, but when I compile bsdoc, I get a bunch of warnings: unused opens, unused variables, shadowed identifiers and so on.

Those shadowed identifiers might be tricky, but the other stuff should be trivial. I could do a PR if you don’t mind.

@hoichi
Copy link
Author

hoichi commented Jan 29, 2019

And yes, those warnings show during compilation of dependent projects, which is why I’m here 🙂

@leostera
Copy link
Collaborator

Hej @hoichi. thanks for filing this issue! — I haven't had time to work on bsdoc for a while now, but I'd happily accept PRs refactoring this and disabling the appropriate warnings :)

@leostera leostera added enhancement New feature or request good first issue Good for newcomers labels Feb 19, 2019
@hoichi
Copy link
Author

hoichi commented Feb 19, 2019

Hey @Ostera. Sure, will look into it in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants