Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes <Radio> and <Checkbox> for styled-components v5 #1050

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes <Radio> and <Checkbox> for styled-components v5 #1050

wants to merge 1 commit into from

Conversation

javiercr
Copy link

Fixes #1049

spoeken
spoeken approved these changes Nov 27, 2020
View reviewed changes
Copy link

@spoeken spoeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😊

@evenromo
Copy link

Would be nice to have this merged or dealt with somehow. Took quite some time to figure out what was causing this issue.

@maxmezzomo
Copy link

Looks nice. In line with the changes mentioned by styled.. Can we get this in?

@d3vhound
Copy link

Ran into this recently. What's preventing this from being merged in?

@gamb
Copy link

gamb commented Apr 24, 2021

@jxnblk ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxmezzomo maxmezzomo maxmezzomo approved these changes

@spoeken spoeken spoeken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkbox component is broken with styled-components v5x.x
6 participants
@javiercr @evenromo @maxmezzomo @d3vhound @gamb @spoeken