Merge pull request #1190 from iisyos/master

Fix type declaration mismatch in scalar stub

Author: mfn

CHANGELOG.md

@@ -3,6 +3,9 @@ CHANGELOG
 
 [Next release](https://github.com/rebing/graphql-laravel/compare/9.11.0...master)
 
+### Fixed
+- Fixed type declaration mismatch in scalar type classes generated by `make:graphql:scalar` command by removing premature type hints from the stub [\#1190 / iisyos](https://github.com/rebing/graphql-laravel/pull/1190)
+
 2025-10-07, 9.11.0
 ------------------
 

src/Console/stubs/scalar.stub

@@ -16,12 +16,12 @@ class DummyClass extends ScalarType implements TypeConvertible
     /**
      * @var string
      */
-    public $name = 'DummyClass';
+    public string $name = 'DummyClass';
 
     /**
-     * @var string
+     * @var ?string
      */
-    public $description = '';
+    public ?string $description = '';
 
     /**
      * Serializes an internal value to include in a response.

tests/Unit/Console/ScalarMakeCommandTest.php

@@ -37,13 +37,13 @@ public static function dataForMakeCommand(): array
                 'inputName' => 'Example',
                 'expectedFilename' => 'GraphQL/Scalars/Example.php',
                 'expectedClassDefinition' => 'Example extends ScalarType implements TypeConvertible',
-                'expectedGraphqlName' => '\$name = \'Example\';',
+                'expectedGraphqlName' => 'public string \\$name = \'Example\';',
             ],
             'ExampleScalar' => [
                 'inputName' => 'ExampleScalar',
                 'expectedFilename' => 'GraphQL/Scalars/ExampleScalar.php',
                 'expectedClassDefinition' => 'ExampleScalar extends ScalarType implements TypeConvertible',
-                'expectedGraphqlName' => '\$name = \'ExampleScalar\';',
+                'expectedGraphqlName' => 'public string \\$name = \'ExampleScalar\';',
             ],
         ];
     }