New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide information about graphql-php breaking changes #676

Closed

mfn opened this issue Sep 13, 2020 · 1 comment

Assignees

Milestone

Collaborator

mfn commented Sep 13, 2020

With the bump of webonxy/graphql-php , some breaking changes on that library are mentioned in the release at https://github.com/webonyx/graphql-php/releases/tag/v14.0.0

Since this library wraps graphql-php but doesn't hide the fact, such breaking changes will leak through (see #673 ).

Scope: make it clear for users of graphql-laravel what happens with the major version bump

mfn added this to the Release 6 milestone

mfn self-assigned this

Collaborator Author

mfn commented Nov 26, 2020

I couldn't think of much more than adding it to the release notes at https://github.com/rebing/graphql-laravel/releases/tag/6.0.0 , basically pointing out the 14.0 release of graphql-php

Also not sure if it's necessary to add it to the readme, let's see what the feedback is

mfn closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment