Same relationship aliased fails to resolve

[edgarsn]

Versions:

• graphql-laravel Version: master branch
• PHP Version: 7.4.3

Description:

Querying same relationship twice with alias fails. I wrote test for it.

Steps To Reproduce:

See test

    public function testRelationshipQueryAlias(): void
    {
        /** @var User $user */
        $user = factory(User::class)->create();

        /** @var Post $postFlagged */
        $postFlagged = factory(Post::class)
            ->create([
                'flag' => true,
                'user_id' => $user->id,
            ]);

        /** @var Post $postNonflagged */
        $postNonflagged = factory(Post::class)
            ->create([
                'user_id' => $user->id,
            ]);

        $graphql = <<<'GRAQPHQL'
{
  users(select: true, with: true) {
    id
    name
    flagged: posts(flag: true) {
      body
      id
      title
    }
    nonflagged: posts(flag: false) {
      body
      id
      title
    }
  }
}
GRAQPHQL;

        $this->sqlCounterReset();

        $result = $this->httpGraphql($graphql);

        $expectedResult = [
            'data' => [
                'users' => [
                    [
                        'id' => (string) $user->id,
                        'name' => $user->name,
                        'flagged' => [
                            [
                                'body' => $postFlagged->body,
                                'id' => (string) $postFlagged->id,
                                'title' => $postFlagged->title,
                            ],
                        ],
                        'nonflagged' => [
                            [
                                'body' => $postNonflagged->body,
                                'id' => (string) $postNonflagged->id,
                                'title' => $postNonflagged->title,
                            ],
                        ],
                    ],
                ],
            ],
        ];
        $this->assertSame($expectedResult, $result);
    }

See output

1) Rebing\GraphQL\Tests\Database\SelectFields\QueryArgsAndContextTests\NestedRelationLoadingTest::testRelationshipQueryAlias
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
             0 => Array &3 (
                 'id' => '1'
                 'name' => 'Kade Oberbrunner'
-                'flagged' => Array &4 (
-                    0 => Array &5 (
-                        'body' => 'Sed autem eum error fugit in quod.'
-                        'id' => '1'
-                        'title' => 'Mr.'
-                    )
-                )
-                'nonflagged' => Array &6 (
-                    0 => Array &7 (
-                        'body' => 'Provident explicabo distinctio illo rerum a exercitationem et.'
-                        'id' => '2'
-                        'title' => 'Miss'
-                    )
-                )
+                'flagged' => Array &4 ()
+                'nonflagged' => Array &5 ()
             )
         )
     )
 )

If i change query to: (basically removing nonflagged)

{
  users(select: true, with: true) {
    id
    name
    flagged: posts(flag: true) {
      body
      id
      title
    }
  }
}

... and change expected result to:

$expectedResult = [
    'data' => [
        'users' => [
            [
                'id' => (string) $user->id,
                'name' => $user->name,
                'flagged' => [
                    [
                        'body' => $postFlagged->body,
                        'id' => (string) $postFlagged->id,
                        'title' => $postFlagged->title,
                    ],
                ],
            ],
        ],
    ],
];

test passes. Is it really a bug or am I missing something? :)

[edgarsn]

After some research, Laravel doesn't support eager load relationship aliasing unfortunatelly (I didn't pay attention previously on that one). Without that I don't think this is even possible, isn't it?

[crissi]

yes not possible easily, i made a hacked solution somewhere in closed prs.

Should be easy when/if this get implemented: laravel/ideas#2183

[mfn]

I think @crissi is referring to #612 which was triggered by #604

Closing it for either a shortcoming we're not able to overcome and/or duplicate of #604

To OP: though I see you already made tests, I'm happy to include tests which assert the "undesired" state which in case in the future this gets fixed and those tests then break, serving as a reminder to update them.