-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow Fixed Params #55
Comments
That's clearly something we need to improve. I agree with the aim to have a single URL for a given endpoint. URL templates are a problem. |
Why isn't The current Wikidata practice of requiring the language to be specified and only supporting a single language at a time seems limiting to me. Shouldn't we be shooting for a model where label language can be specified on a per-label basis (with the global language as a degenerate case)? |
If I remember correctly it is also possible to specify the country as a property in the OpenCorporates recon service. I think supplying languages string-by-string could be doable but not a substitute for specifying the preferred language of the user. At the moment, the language setting of the Wikidata recon service determines in which language the labels and descriptions of items are returned - not the language of the data to reconcile. The two are really different: I could want to reconcile data from a language I am not familiar with ( |
Please comment about lang in the related issue, not here. |
@tfmorris I agree that And I agree that
I disagree that the protocol doesn't need to know whether a param is global or per-row. A global param may be handled more efficiently in the query to the underlying storage. Having said that, your suggestion is an excellent work-around until we enrich the protocol to add "fixed params". |
I think I can present another use case for such parameters: I am reconciling against SKOS concepts in conceptSchemes maintained by different user accounts. At least one of these levels (user accounts) introduces the possibility that the same entity appears in multiple (say, competing) collections. Currently, I am solving this by adding Granted, the backend is one single flat index of concept items with For what it's worth, I thought I needed a way to signal to users what vocabularies (by which accounts) are available, so I have added an - out-of-spec - field |
Would be nice to set some params globally, without having to add columns of fixed values.
#52 gives two examples:
language
jurisdiction
Extra example:
country
fixed to "Bulgaria"These fixed params are very similar to "extra props" and need the same flexibility.
Requirements:
language
), or related to the current record (egjurisdiction, country
)#52 describes the current practice of hardcoding the param value in the URL
https://wikidata.reconci.link/api/{lang}
https://wikidata.reconci.link/api
)The text was updated successfully, but these errors were encountered: