Make the library usable without the \Recurly_Client::$apiKey

[romainneutron]

It would be great if the library would be usable without the static property. It would allow us to have multiple recurly clients instantiated at the same time.
At the moment, the __createNodeObject factory in base.php prevents us to do that.

[drewish]

Could you say more about the goal of multiple clients? I'd think resources would preserve the client they were initialized with and pass that on other resources that they load.

[romainneutron]

We're having two client for billing inside USA and outside USA (I don't know the details, however it seems required for legal reasons)

Resource preserve the client they were initialized with except in some edge case, when \Recurly_Resource::__createNodeObject is called, it creates new resources without the client:

#0  Recurly_Client->__construct() called at [.../vendor/recurly/recurly-client/lib/recurly/base.php:13]
#1  Recurly_Base->__construct() called at .../vendor/recurly/recurly-client/lib/recurly/resource.php:19]
#2  Recurly_Resource->__construct() called at [.../vendor/recurly/recurly-client/lib/recurly/plan.php:40]
#3  Recurly_Plan->__construct() called at [.../vendor/recurly/recurly-client/lib/recurly/base.php:425]
#4  Recurly_Base::__createNodeObject() called at [.../vendor/recurly/recurly-client/lib/recurly/base.php:255]
#5  Recurly_Base::__parseResponseToNewObject() called at [.../vendor/recurly/recurly-client/lib/recurly/base.php:29]
#6  Recurly_Base::_get() called at [.../vendor/recurly/recurly-client/lib/recurly/plan.php:46]
#7  Recurly_Plan::get() 

[bhelx]

@romainneutron can you provide any example code as to how you are trying to accomplish this?

[nsanden]

I'd love to see the library updated to not use static at all and name spaced. At the moment, it feels very uncomfortable to use.

[bhelx]

@nsanden I think we agree on the principle, but that would mean a very difficult upgrade path for our customers.

[nsanden]

php sdk v2 perhaps :)

[aaron-junot]

Closing out this issue due to the fact that it will not be implemented in this major version of the library