What’s the best way of using getting a 3D secure token?

[zoe-edwards]

Currently I’m using this:

try {
    $subscription->create();
} catch (Recurly_ValidationError $validationError) {
    foreach ($validationError->errors as $error) {
        if ($error instanceof Recurly_TransactionError) {
            if ($error->error_code === 'three_d_secure_action_required') {
                return response([
                    'status' => 'Accepted',
                    'actionTokenId' => $error->three_d_secure_action_token_id
                ], 202);
            }
        }
    }
    throw $validationError;
}

Other than refactoring it out into methods, that’s as simple as I can make it. Is there another way I’m missing?

This would be better:

try {
    $subscription->create();
} catch (Recurly_TransactionError $error) {
    if ($error->error_code === 'three_d_secure_action_required') {
        return response([
            'status' => 'OK',
            'actionTokenId' => $error->three_d_secure_action_token_id
        ], 202);
    }
    throw $error;
}

[joannasese]

Hi @ThomasEdwards. I see what you're saying. I'm looking into if there's a simpler way or something we can change, but initial reaction is that your approach is as straight-forward as it can be at this moment.

[zoe-edwards]

I realise that anything at this level would probably break all backwards compatibility, so maybe a v3 one day? 😌Thanks!

[joannasese]

Hi @ThomasEdwards.

After some investigating, I was alerted to this script. It's a little less verbose, but it's brittle in that it only works if you know your first error is going to be a three_d_secure_action_required error. Just something I thought to show you in case you hadn't already seen it.

[zoe-edwards]

Oh that’s interesting – it presumes that the 3D secure validation will always be in errors[0] – is that always the case?

[joannasese]

No, not always. I perceive your approach as safer, as it considers more use cases.

[zoe-edwards]

Ah yeah I’d rather have one endpoint that covers all the bases than having seperate ones, thanks anyway!