Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for New York city Taxi and Limousine Commission trip record data #8

Open
kou opened this issue Aug 28, 2022 · 3 comments
Open

Add support for New York city Taxi and Limousine Commission trip record data #8

kou opened this issue Aug 28, 2022 · 3 comments

Comments

@kou
Copy link
Member

kou commented Aug 28, 2022

This dataset's license must be public domain (CC0).
@kou
Copy link
Member Author

kou commented Aug 28, 2022

https://opendata.cityofnewyork.us/open-data-law/ says "public".

@kou
Copy link
Member Author

kou commented Aug 31, 2022

https://www1.nyc.gov/site/tlc/about/tlc-trip-record-data.page

@otegami otegami mentioned this issue Aug 31, 2022
Merged
kou referenced this issue in red-data-tools/red-datasets Sep 5, 2022
@otegami @kou
Add support for New York city's Taxi and Limousine Commission yellow …
520694e 
…taxi trip records (#151)

TODO: We should consider about red-parquet dependency before we release a new version. 

## Related Issue
- https://github.com/red-data-tools/red-datasets/issues/150

## What I did
- added red-parquet to runtime dependencies
- added New York city's taxi and limousine commission trip yellow taxi support
- added simple unit test

### Details
- [Yellow Trips Data Dictionary](https://www1.nyc.gov/assets/tlc/downloads/pdf/data_dictionary_trip_records_yellow.pdf)
    - ref: https://www1.nyc.gov/site/tlc/about/tlc-trip-record-data.page

## What I Didn't
- added following datasets related with NYC Taxi and Limousine Commission
    - Green Trips Data
    - FHV Trips Data
    - High Volume FHV Trips Data

## What I checked
- ran tlc-trip-yellow-taxi example
```console
% ruby example/tlc-trip-yellow-taxi.rb 
[:creative_mobile_technologies, 2022-01-01 09:35:40 +0900, 2022-01-01 09:53:29 +0900, 2.0, 3.8, :standard_rate, false, 142, 236, :credit_card, 14.5, 3.0, 0.5, 3.65, 0.0, 0.3, 21.95, 2.5, 0.0]
[:creative_mobile_technologies, 2022-01-01 09:33:43 +0900, 2022-01-01 09:42:07 +0900, 1.0, 2.1, :standard_rate, false, 236, 42, :credit_card, 8.0, 0.5, 0.5, 4.0, 0.0, 0.3, 13.3, 0.0, 0.0]
```

## Notes for reviewers
- Would you give some advice about `Class Name`
    - `TLCTripYellowTaxi` or `TLCTrip::YellowTaxi` or Should I add `NYC` as a prefix
- If you don't mind, I want to try to add the other following datasets too
    - Green Trips Data
    - FHV Trips Data
    - High Volume FHV Trips Data

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@otegami otegami mentioned this issue Sep 7, 2022
Closed
@kou kou transferred this issue from red-data-tools/red-datasets Sep 22, 2022
@otegami
Copy link
Member

otegami commented Sep 23, 2022

Thank you for transferring this issue.

The rest datasets about NYC Taxi and Limousine Commission haven't been implemented yet.

  • FHV Trips Data
  • High Volume FHV Trips Data

@otegami otegami mentioned this issue Sep 23, 2022
Closed
@otegami otegami mentioned this issue Nov 2, 2022
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kou @otegami