Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: context merging for dr dashboard #783

Closed

Conversation

debjyoti-pandit
Copy link
Contributor

fixes: #672

@debjyoti-pandit
Copy link
Contributor Author

/hold

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: debjyoti-pandit
Once this PR has been reviewed and has the lgtm label, please assign sanjalkatiyar for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@debjyoti-pandit
Copy link
Contributor Author

/assign @SanjalKatiyar
/assign @bipuladh

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SanjalKatiyar
Copy link
Collaborator

we simply have to add ex: "CSVStatusesContext.Provider" to "CSVStatusesContextProvider" FC, which will take values as a prop and pass it down to its "children"... we can reduce the complexity of this PR... most of the thing are not necessarily needed...

example: https://github.com/openshift/console/blob/master/frontend/public/components/app.jsx#L241
see "ModalProvider" FC, which internally passes value down to "children".

@SanjalKatiyar
Copy link
Collaborator

we simply have to add ex: "CSVStatusesContext.Provider" to "CSVStatusesContextProvider" FC, which will take values as a prop and pass it down to its "children"... we can reduce the complexity of this PR... most of the thing are not necessarily needed...

example: https://github.com/openshift/console/blob/master/frontend/public/components/app.jsx#L241 see "ModalProvider" FC, which internally passes value down to "children".

@debjyoti-pandit

@debjyoti-pandit
Copy link
Contributor Author

we simply have to add ex: "CSVStatusesContext.Provider" to "CSVStatusesContextProvider" FC, which will take values as a prop and pass it down to its "children"... we can reduce the complexity of this PR... most of the thing are not necessarily needed...
example: https://github.com/openshift/console/blob/master/frontend/public/components/app.jsx#L241 see "ModalProvider" FC, which internally passes value down to "children".

@debjyoti-pandit

On it, currently working on tests and am stuck. once I and done will fix this PR.

@SanjalKatiyar
Copy link
Collaborator

can we update this PR @debjyoti-pandit sometime as well ?? pending comments for quite a while...

@debjyoti-pandit
Copy link
Contributor Author

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[perf-improv] Create separate provider for the context and pass its descendants as a "children"
4 participants