-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: context merging for dr dashboard #783
fix: context merging for dr dashboard #783
Conversation
/hold |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: debjyoti-pandit The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @SanjalKatiyar |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
we simply have to add ex: "CSVStatusesContext.Provider" to "CSVStatusesContextProvider" FC, which will take values as a prop and pass it down to its "children"... we can reduce the complexity of this PR... most of the thing are not necessarily needed... example: https://github.com/openshift/console/blob/master/frontend/public/components/app.jsx#L241 |
|
On it, currently working on tests and am stuck. once I and done will fix this PR. |
can we update this PR @debjyoti-pandit sometime as well ?? pending comments for quite a while... |
Sure |
fixes: #672