Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Preference for colorblind safe colors #114

Closed
edwardrowe opened this issue Aug 28, 2017 · 1 comment
Closed

Add Preference for colorblind safe colors #114

edwardrowe opened this issue Aug 28, 2017 · 1 comment
Labels
enhancement good first issue A good issue to tackle for new contributors hacktoberfest

Comments

@edwardrowe
Copy link
Contributor

edwardrowe commented Aug 28, 2017

The Diff and operation colors could use a color blind safe palette. Note this may be moot with the resolution of Issue #101, but in the meantime I suspect it's a problem.

Use http://colororacle.org/ to help evaluate the color choices.

For implementation, I would add a flag to base Drawer to specify to draw as a ColorBlind variant. HighlightColor property then be reworked to call one of two properties, depending on their color blind setting.

Stretch goal would be to consider patterns in the operation color strips. The challenge to that is Drawers don't really support drawing anything except rectangles at the moment, which is handled in the base drawer which gets a color from inherited classes.

As far as storage of the colorblind setting, this is dependent on #206. For now the simplest solution is best. A checkbox on the window that sets and gets a value in MulliganUserPreferences would be just fine.

This should also leverage Unity's Preference system Edit: Best practices for user preferences for plugins has changed. This is now dependent on a robust user preferences system (#206).

@edwardrowe edwardrowe changed the title Add Preference for Colorblind Safe Colors Add Preference for colorblind safe colors Aug 28, 2017
@edwardrowe edwardrowe added good first issue A good issue to tackle for new contributors hacktoberfest labels Oct 2, 2019
@edwardrowe
Copy link
Contributor Author

I'm gonna call this done with #206. The only other colors I might change are the "Add", "Modify", "Remove", etc colors, but the Ux really isn't that dependent on those colors. I suspect color blind users would have no problem using the tool, now that the Diff colors can be assigned.

@edwardrowe edwardrowe added the fixed in development The issue is fixed in the development branch label Jan 17, 2020
@edwardrowe edwardrowe removed the fixed in development The issue is fixed in the development branch label Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue A good issue to tackle for new contributors hacktoberfest
Projects
None yet
Development

No branches or pull requests

1 participant