Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes to the Damage Assessment section to reflect the Red Cross' current Direct Client Assistance (DCA) model #173

Closed
jim-mcgowan opened this issue Nov 30, 2018 · 9 comments

Comments

@jim-mcgowan
Copy link
Member

jim-mcgowan commented Nov 30, 2018

On the Details tab of incident reports, make the following changes to the Damage Assessment section:

  1. Add Multi-family home to the Structure type* pop-up menu between Single family home and Apartment;
  2. Change the units fields from Units destroyed*, Units major*, Units minor* and Units affected* to Units not livable* and Units livable*.

damage assessment

@pjsier
Copy link
Contributor

pjsier commented Dec 13, 2018

@OhMcGoo 1. here is straightforward, but I have some questions for 2. How should we handle existing data here, since it doesn't sound like the new definitions map cleanly onto the old ones? Should we show the make the current fields read-only so that they're still visible on older incidents?

@jim-mcgowan
Copy link
Member Author

@pjsier: Regarding 2., what if we first insert Units not livable and Units livable as two additional fields (above Units destroyed) and make them mandatory while making the others no longer mandatory? Once regions have transitioned to using the new designations (say, after a month), we can make the old designations read only. I'm thinking about how we transition as incident reports can often be worked on for up to 2-3 weeks.

@kfogel
Copy link
Member

kfogel commented Sep 25, 2019

Decided w/ @OhMcGoo: Every region is going to make the switch to these new damage classifications, "Units not liveable" and "Units livable". However, the old data still has to be retrievable and displayable, so this isn't totally trivial.

@jim-mcgowan jim-mcgowan added the M label Nov 25, 2019
@jim-mcgowan jim-mcgowan added this to the One Red Cross milestone Nov 25, 2019
@frankduncan frankduncan self-assigned this Jun 18, 2020
@frankduncan
Copy link
Contributor

Coming up to speed on this.

What do we think about setting adding in a check that says if the incident date is newer than July 1, 2020, do not present the old fields in the edit interface. Then, in a month (or whatever grace period is needed), we remove the check and remove the old ones completely?

Then, for display purposes, if we see values in the old columns, we display the old values. If we don't see any, we display only the new data (which could be zero)?

@jim-mcgowan
Copy link
Member Author

jim-mcgowan commented Jun 19, 2020 via email

@kfogel
Copy link
Member

kfogel commented Jun 26, 2020

@jim-mcgowan
Copy link
Member Author

Please hold off on this change. NHQ is making changes to damage assessment classifications.

@jim-mcgowan
Copy link
Member Author

Damage assessment classifications are going to remain as-is (Destroyed, Major, Minor and Affected). It is likely that a new classification will be added (Uninhabitable) later this fall but that is still TBD. I am closing this issue.

@kfogel
Copy link
Member

kfogel commented Dec 3, 2020

Note that in our 2020-11-30 meeting, Clara Walker noted that this issue might need to be reopened, as new damage assessment classifications may be coming out as part of the move to RC Care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants