Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Spreadsheet links from DAT Scheduling page #187

Closed
jim-mcgowan opened this issue Aug 16, 2019 · 6 comments
Closed

Remove Spreadsheet links from DAT Scheduling page #187

jim-mcgowan opened this issue Aug 16, 2019 · 6 comments

Comments

@jim-mcgowan
Copy link
Member

On the DAT Scheduling page, under Calendar Details, remove the Spreadsheet links listed under the current and next two months.

DAT Scheduling

@kfogel
Copy link
Member

kfogel commented Sep 25, 2019

Note that this is because the functionality (on the page after you click the link) is essentially broken -- you can't actually download a spreadsheet. So when we fix this issue, we should make sure another one is filed reminding us that some day we'd like to actually get spreadsheets working. However, until they are, let's just remove the links so they don't distract or mislead people.

@jim-mcgowan jim-mcgowan added the XS label Nov 25, 2019
@jim-mcgowan jim-mcgowan added this to the One Red Cross milestone Nov 25, 2019
@frankduncan
Copy link
Contributor

How's it supposed to work? Might be a quick fix to just have the spreadsheets work.

@frankduncan
Copy link
Contributor

@OhMcGoo ^^

@frankduncan
Copy link
Contributor

It looks like it's blank because the "spreadsheet_ordinal" for shifts isn't being sent in the admin console. THe "ordinal" is being set, but there needs to be a "spreadsheet_ordinal" too. When I set that on the "Greater Chicago - Greater Chicago" shift to 2001, the spreadsheet starts working.

@jim-mcgowan
Copy link
Member Author

@frankduncan: I think it produced an actual spreadsheet that looked something like this:
grid.pdf

The functionality, conceptually, is good but the execution is bad (and ugly). It might be worth keeping but we'd need to design it better. Maybe, instead of Spreadsheet, it could say Print Schedule. Then we fix up the linked page and the output.

Still, it seems like a lotta work.

@frankduncan
Copy link
Contributor

Change "Spreadhsheet" to "Printable" and remove Grid is the new definition of this issue.

frankduncan pushed a commit that referenced this issue Jul 10, 2020
From the DAT Scheduling page, the spreadsheet/grid links were
confusingly named, and the grid itself was unusable.

Issue #187: Remove Spreadsheet links from DAT Scheduling page
frankduncan pushed a commit that referenced this issue Jul 10, 2020
With #187, we no longer link to the grid, and so we should blow
the html/css used to generate it away to clean up the codebase.

Issue #187: Remove Spreadsheet links from DAT Scheduling page
frankduncan pushed a commit that referenced this issue Jul 30, 2020
With #187, we no longer link to the grid, and so we should blow
the html/css used to generate it away to clean up the codebase.

Issue #187: Remove Spreadsheet links from DAT Scheduling page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants