Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail on missing ~/.docker dir #43

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PhrozenByte
Copy link
Contributor

@PhrozenByte PhrozenByte commented Aug 7, 2024

Description

This is the then announced "might be necessary, idk…" follow-up to #39 (8828a23). See #39 for background info.

Fixes the main run() raising an ENOENT error if ~/.docker/ doesn't exist when writing the new Docker config (#42).

This time I can't really say that it happens "frequently" with GitHub-hosted runners, it has been 5 months since @divyansh42 merged my initial (and apparently incomplete) fix (#39) in March. Still no idea why ~/.docker/ sometimes doesn't exist… Still it causes workflows to fail, what still is annoying. The last error happened in a private repo's workflow, thus I can't share the link…

These changes are again UNTESTED! Simply because I still don't know how. I still know a little JavaScript, but still have next to zero experience with NodeJS (and honestly don't want to learn it), so please keep this in mind. I still believe that providing something to fix #42 is better than nothing (so many "still"s 😆).

Related Issue(s)

Fixes #42
Follow-up to #39
Related to #18
Related to #36 (maybe?)
Related to #41 (maybe?)

Checklist

  • This PR includes a documentation change
  • This PR does not need a documentation change

  • This PR includes test changes
  • This PR's changes are already tested
  • What tests?

  • This change is not user-facing
  • This change is a patch change
  • This change is a minor change
  • This change is a major (breaking) change

Changes made

@PhrozenByte
Copy link
Contributor Author

CI isn't running because GitHub considers this project to be too sleepy… 😆

See https://github.com/redhat-actions/podman-login/actions/workflows/ci.yml

This scheduled workflow is disabled because there hasn't been activity in this repository for at least 60 days. Enable this workflow to resume scheduled runs.

I know this very well, happened to me before, too. I've created a GitHub Action in 2022 to circumvent this, you might want to add it to this repo. There are a few other GitHub Actions in the marketplace trying to do the same, but AFAIK mine is the only that works reliably without requiring "ghost commits" or running code on some other server, but just uses GitHub workflows to keep GitHub workflows alive. See https://github.com/marketplace/actions/github-workflow-immortality

@PhrozenByte
Copy link
Contributor Author

PhrozenByte commented Sep 11, 2024

Looks like its getting more frequent again, I had multiple runs fail in the past few days, including a public one: (1) (as before, note that the parallel jobs doing exactly the same don't fail for some unknown reason)

Even tough I'm no fan of pinging people, but since you've merged the last one: @divyansh42, wdyt?

@mdhowle
Copy link

mdhowle commented Sep 22, 2024

I have been running into this issue as well.

These changes are again UNTESTED!

I duplicated your changes in my fork. It fixed it in my case.

I still know a little JavaScript, but still have next to zero experience with NodeJS (and honestly don't want to learn it)

Amen, brother. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] podman login fails when missing docker configs
2 participants