Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The bundle build doesn't take the IMAGE and VERSION variable into account. #426

Open
yohancourbe opened this issue Feb 1, 2023 · 1 comment

Comments

@yohancourbe
Copy link

Describe the bug
The bundle manifest doesn't take the IMAGE and VERSION variable into account. Its value is statically set to containerImage: quay.io/redhat-developer/gitops-backend-operator:v0.0.3 in config/manifests/bases/gitops-operator.clusterserviceversion.yaml and bundle/manifests/gitops-operator.clusterserviceversion.yaml. The catalog will show that in the Openshift UI.

To Reproduce
Steps to reproduce the behavior:

  • Follow build instructions with a custom repository in IMAGE

Expected behavior
The catalog resource shows my custom repository as container image

Screenshots
n/a

Additional context
n/a

@yohancourbe yohancourbe changed the title The bundle manifest doesn't take the IMAGE and VERSION variable into account. The bundle build doesn't take the IMAGE and VERSION variable into account. Feb 1, 2023
@anandf
Copy link
Member

anandf commented May 15, 2023

I am not able to reproduce this problem.

export IMAGE=quay.io/anjoseph/gitops-operator VERSION=1.8.0

and then ran

make bundle

It generated the ClusterServiceVersion with the right IMAGE and VERSION in the location bundle/manifests/gitops-operator.clusterserviceversion.yaml

--- a/bundle/manifests/gitops-operator.clusterserviceversion.yaml
+++ b/bundle/manifests/gitops-operator.clusterserviceversion.yaml
@@ -135,10 +135,11 @@ metadata:
     capabilities: Deep Insights
     console.openshift.io/plugins: '["gitops-plugin"]'
     containerImage: quay.io/redhat-developer/gitops-operator
+    createdAt: "2023-05-15T07:53:31Z"
     description: Enables teams to adopt GitOps principles for managing cluster configurations
       and application delivery across hybrid multi-cluster Kubernetes environments.
     operators.openshift.io/infrastructure-features: '["disconnected"]'
-    operators.operatorframework.io/builder: operator-sdk-v1.22.0-ocp
+    operators.operatorframework.io/builder: operator-sdk-v1.28.1
     operators.operatorframework.io/project_layout: go.kubebuilder.io/v3
     repository: https://github.com/redhat-developer/gitops-operator
     support: Red Hat
@@ -603,7 +604,7 @@ spec:
                   value: openshift-gitops
                 - name: OPERATOR_NAME
                   value: gitops-operator
-                image: quay.io/redhat-developer/gitops-operator:latest
+                image: quay.io/anjoseph/gitops-operator:1.8.0
                 livenessProbe:
                   httpGet:
                     path: /healthz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants