Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiate and manage services through Operator #2613

Closed
6 tasks done
kadel opened this issue Feb 17, 2020 · 10 comments
Closed
6 tasks done

Instantiate and manage services through Operator #2613

kadel opened this issue Feb 17, 2020 · 10 comments
Assignees
Labels
kind/epic An issue categorized as a high-level Epic. Needs to be scoped and broken down in 1+ stories/tasks lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. v2 Issue or PR that applies to the v2 of odo

Comments

@kadel
Copy link
Member

kadel commented Feb 17, 2020

User Story

As a user, I want to create a new instance of my database or another service managed by operators So that I can use it (link it) with my application

Acceptance Criteria

Links

/area service-operators
/area service

@kadel
Copy link
Member Author

kadel commented Feb 19, 2020

/assign @dharmit @girishramnani

@girishramnani
Copy link
Contributor

a high level thought process around this was -

so a user can provide values while creating the CRD e.g.
odo service create KafkaTopic --operator strimzi-operator --replicas 1 and we can use the CRD as shown here https://strimzi.io/docs/latest/#con-custom-resources-example-str to validate that replicas is a valid argument.

@kadel
Copy link
Member Author

kadel commented Feb 19, 2020

  • to allow creating different CRDs present under same operator we could have the cli which looks like this
    odo service create <<CRD_NAME>> --operator <<operator>>
    e.g. odo service create KafkaTopic --operator strimzi-operator

I would prefer the other way around. The operator's name is basically the service name. So the command should be odo service create <operator> with optional --crd flag that would be required only if Operator provides more than one API/CRD (OpenShift webconsole calls this "Provided APIs")

odo service create mongodb-enterprise.v1.2.4   --crd MongoDB

@dharmit
Copy link
Member

dharmit commented Feb 19, 2020

to allow creating different CRDs present under same operator we could have the cli which looks like this
odo service create <<CRD_NAME>> --operator <>
e.g. odo service create KafkaTopic --operator strimzi-operator

This makes sense and I'm not suggesting that it's a wrong idea, but to keep things in sync with how we do it right now with services and plans (Service Catalog), I'd prefer odo service create <operator> --crd <crd-name>.

@dharmit
Copy link
Member

dharmit commented Apr 1, 2020

@kadel @girishramnani last two points talk about odo service describe command. But we don't have that command in the workflow right now. Do we mean odo service list -o json?

@openshift-ci-robot openshift-ci-robot added the kind/user-story An issue of user-story kind label Apr 1, 2020
@girishramnani
Copy link
Contributor

we decided to do describe after the instantiation was done as that instantiation was a more "critical" piece.

@dharmit
Copy link
Member

dharmit commented Apr 1, 2020

It's not about when to do it. I understand that it's not essential right now. I'm pointing to there being no odo service describe in the first place.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 25, 2021
@dharmit
Copy link
Member

dharmit commented Jan 29, 2021

/lifecycle frozen

@openshift-ci-robot openshift-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 29, 2021
@girishramnani
Copy link
Contributor

We have completed all ACs this epic hence closing

@rm3l rm3l added the v2 Issue or PR that applies to the v2 of odo label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/epic An issue categorized as a high-level Epic. Needs to be scoped and broken down in 1+ stories/tasks lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. v2 Issue or PR that applies to the v2 of odo
Projects
Archived in project
Development

No branches or pull requests

6 participants