Unit tests failing with security error

[mik-dass]

/kind bug

Actual behavior

[/home/travis/gopath/src/github.com/openshift/odo/tests/helper/helper_generic.go:28] - G404 (CWE-338): Use of weak random number generator (math/rand instead of crypto/rand) (Confidence: MEDIUM, Severity: HIGH)
  > rand.Intn(len(letterBytes))
[/home/travis/gopath/src/github.com/openshift/odo/pkg/util/util.go:87] - G404 (CWE-338): Use of weak random number generator (math/rand instead of crypto/rand) (Confidence: MEDIUM, Severity: HIGH)
  > rand.Intn(len(letterRunes))

https://travis-ci.com/github/openshift/odo/jobs/349244708

Expected behavior

Unit tests should pass

[kadel]

@mik-dass @girishramnani, wasn't this fixed by #3358?

[girishramnani]

yes it should have been

[girishramnani]

can @mik-dass rebase?

[girishramnani]

confirming that there is no instance of math/rand in upstream/master

[mik-dass]

This was created when the error was there. #3358 didn't mention it closes this issue, so it stayed open.