Refactor odo specific packages like url, storage etc

[mik-dass]

/kind code-refactoring

Acceptance Criteria

odo specific packages like storage, url etc should have interface so that it becomes easier to use and mock them.

The packages we are scoping for refactoring are

• Application
• Catalog
• Component
• Project
• Service (Refactor underlying code for "odo service" commands #4242)
• Storage (@mik-dass)
• URL (@mik-dass [WIP] Refactor idea #4185)

[girishramnani]

I would suggest breaking this into smaller tasks if we want to include all packages

[mik-dass]

I would suggest breaking this into smaller tasks if we want to include all packages

Yes, we would break this into smaller tasks once a framework for the packages is designed.

[mik-dass]

I have added the doc regarding the refactoring here https://docs.google.com/document/d/1miLfw0m0nWGmoBsYr9jkHp0mFSSXW84eLv_dSRC8Sm4/edit?usp=sharing. @metacosm @girishramnani @kadel @adisky @dharmit Please have a look and share your feedback.

[dharmit]

@mik-dass you've done a great job of separating the code into different files especially at occlient and kclient level. I think you had something for url package that was more interface-y. Are you planning to open a PR for it?

@girishramnani you mentioned that you were going to work on the config part of context package. However, I don't think @adisky will be working further on context package refactor. Can you please share how you plan to take this further?

[dharmit]

Either this has to be done on a high priority or completely dropped. We can't keep dragging refactoring task into sprints if it's not making sense to anyone to work upon. Can't keep just @mik-dass working on it all the time.

@kadel @girishramnani @adisky

/priority high

[mik-dass]

@mik-dass you've done a great job of separating the code into different files especially at occlient and kclient level. I think you had something for url package that was more interface-y. Are you planning to open a PR for it?

The PR #4185 was an concept. I clean it up and it will be ready for review.

[dharmit]

Closing this since we already refactored url and storage packages and we can reference that for further refactoring, if any.

/close

[openshift-ci-robot]

@dharmit: Closing this issue.

In response to this:

Closing this since we already refactored url and storage packages and we can reference that for further refactoring, if any.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.