-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor all the cli packages #4145
Comments
Also as noted at #4057 all cli commands should follow Complete/Validate/Run pattern |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Currently the cli packages break the original odo architecture
Kclient
directlyroutes
are supportedAlso the cli packages contain alot of logic which should be moved to lower layers of the code. Ideally cli packages should only be responsible for collecting information from user, showing them information and building structs that the lower layers need.
The text was updated successfully, but these errors were encountered: