Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If build fails, seems retrying indefinitively and hard to stop #6173

Closed
jeffmaury opened this issue Sep 26, 2022 · 2 comments
Closed

If build fails, seems retrying indefinitively and hard to stop #6173

jeffmaury opened this issue Sep 26, 2022 · 2 comments
Labels
area/dev Issues or PRs related to `odo dev` kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation priority/Medium Nice to have issue. Getting it done before priority changes would be great.

Comments

@jeffmaury
Copy link
Member

/kind bug

What versions of software are you using?

Operating System:
Win10Pro

Output of odo version:

odo v3.0.0-rc2 (39a9a2874)

Server: https://api.sandbox-m2.ll9k.p1.openshiftapps.com:6443
Kubernetes: v1.23.5+012e945

How did you run odo exactly?

odo dev

Actual behavior

Tried to do odo dev on several components on Red Hat Developer Sandbox and the Maven build fails because of OutOfMemory errror but then seems Maven build is retried and it's very hard to stop the loop

Expected behavior

Loop should be limited at least (3 to 5 retries by default ?)

Any logs, error output, etc?
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 26, 2022
@rm3l rm3l added the area/dev Issues or PRs related to `odo dev` label Sep 28, 2022
@rm3l rm3l added this to odo Project Sep 29, 2022
@rm3l rm3l changed the title If buils fails, seems retrying indefinitively and hard to stop If build fails, seems retrying indefinitively and hard to stop Oct 10, 2022
@kadel
Copy link
Member

kadel commented Feb 23, 2023

Agreed, odo should have a limit on retries. It should try 3 times and then stop trying until it detects some changes.

@kadel kadel added priority/Medium Nice to have issue. Getting it done before priority changes would be great. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation and removed kind/bug Categorizes issue or PR as related to a bug. labels Feb 23, 2023
@rm3l rm3l mentioned this issue Mar 23, 2023
Closed
3 tasks
@rm3l
Copy link
Member

rm3l commented Mar 30, 2023 •
edited
Loading

Closing this as a duplicate of #6671. In #6671, we decided to make odo dev not retry until there is a manual sync triggered (by pressing p) or until it detects new changes (unless running with --no-watch).

Also, in #6196 (v3.10.0), we allowed canceling odo dev at any phase. So it should not be easier to stop the execution if needed.

@rm3l rm3l closed this as not planned Won't fix, can't repro, duplicate, stale Mar 30, 2023
@github-project-automation github-project-automation bot moved this to Done ✅ in odo Project Mar 30, 2023
@rm3l rm3l added kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation and removed needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/dev Issues or PRs related to `odo dev` kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
odo Project
Archived in project
after v3.0.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kadel @rm3l @jeffmaury