Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Odo should support multiple k8s definition in a single yaml/inlined field #6275

Closed
yangcao77 opened this issue Oct 31, 2022 · 0 comments · Fixed by #6372
Closed

Odo should support multiple k8s definition in a single yaml/inlined field #6275

yangcao77 opened this issue Oct 31, 2022 · 0 comments · Fixed by #6372
Assignees
@valaparthvi
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/bug Categorizes issue or PR as related to a bug. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Milestone
v3.4.0 🚀

Comments

@yangcao77
Copy link
Contributor

/kind bug

What versions of software are you using?

Operating System:

Output of odo version:

How did you run odo exactly?

For example, for the sample devfile and k8s yaml defined in https://github.com/devfile-samples/devfile-sample-java-springboot-basic/pull/9/files

do odo create, odo push and odo deploy

Actual behavior

odo only create the very top resource definition in the k8s yaml file. In this example, it creates the deployment, and ignores the service.

Expected behavior

odo should not restrict the usage, it should allows multiple objects in the yaml file, and deploys all.

Any logs, error output, etc?
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 31, 2022
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Oct 31, 2022
@rm3l rm3l added this to odo Project Oct 31, 2022
@kadel kadel added the priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). label Oct 31, 2022
@rm3l rm3l added the area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. label Oct 31, 2022
@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Nov 21, 2022
@rm3l rm3l added this to the v3.4.0 🚀 milestone Nov 23, 2022
@valaparthvi valaparthvi mentioned this issue Dec 5, 2022
Merged
3 tasks
@kadel kadel mentioned this issue Dec 5, 2022
Closed
@openshift-merge-robot openshift-merge-robot moved this to Done ✅ in odo Project Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valaparthvi valaparthvi

Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/bug Categorizes issue or PR as related to a bug. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Projects
odo Project
Archived in project
Milestone
v3.4.0 🚀
Development

Successfully merging a pull request may close this issue.

Add support for parsing multiple k8s definition in a single Devfile K8s component valaparthvi/odo
4 participants
@kadel @rm3l @valaparthvi @yangcao77