Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX inconsistency when handling commands bound to events #6573

Closed
rm3l opened this issue Feb 6, 2023 · 0 comments · Fixed by #6574
Closed

UX inconsistency when handling commands bound to events #6573

rm3l opened this issue Feb 6, 2023 · 0 comments · Fixed by #6574
Assignees
Labels
area/dev Issues or PRs related to `odo dev` area/UX Issues or PRs related to User Experience kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@rm3l
Copy link
Member

rm3l commented Feb 6, 2023

/kind bug
/area dev

What versions of software are you using?

Operating System:
Fedora 37, kernel 6.1.9-200.fc37.x86_64

Output of odo version:
odo v3.6.0 (eeda644)

How did you run odo exactly?

$ odo init --name my-java-wildfly --devfile java-wildfly --starter microprofile-openapi
$ odo dev

Actual behavior

$ odo dev
  __
 /  \__     Developing using the "my-java-wildfly" Devfile
 \__/  \    Namespace: default
 /  \__/    odo version: v3.6.0
 \__/

↪ Running on the cluster in Dev mode
 •  Waiting for Kubernetes resources  ...
 ✓  Added storage m2-repository to component
 ⚠  Pod is Pending
 ✓  Pod is Running
 ✓  Syncing files into the container [109ms]
 ✓  Executing copy-galleon command "cp -Rf /opt/jboss/container/wildfly/s2i/galleon/galleon-m2-repository /tmp/. && cp -Rf /opt/wildfly /tmp/." on container "wildfly" [960ms]
 ✓  Executing provision-server command "/usr/local/s2i/assemble && cp -Rf $JBOSS_HOME ." on container "wildfly" [8s]
 ✓  Executing store-config command "mkdir $STANDALONE_RESTORE && cp -f $JBOSS_HOME/standalone/configuration/standalone.xml $STANDALONE_RESTORE/standalone.xml" on container "wildfly" [47ms]
 ✓  Building your application in container (command: compile) [47s]
 ✓  Building your application in container (command: copy-artifact) [51ms]
 •  Executing the application (command: run)  ...
 -  Forwarding from 127.0.0.1:20001 -> 16686

 -  Forwarding from 127.0.0.1:20002 -> 8080

Expected behavior

The following lines provide too much info, and are not consistent with how the other commands (build, run, debug) are displayed in the output.
Here we display the whole command lines, which adds a lot of unnecessary clutter.

 ✓  Executing copy-galleon command "cp -Rf /opt/jboss/container/wildfly/s2i/galleon/galleon-m2-repository /tmp/. && cp -Rf /opt/wildfly /tmp/." on container "wildfly" [960ms]
 ✓  Executing provision-server command "/usr/local/s2i/assemble && cp -Rf $JBOSS_HOME ." on container "wildfly" [8s]
 ✓  Executing store-config command "mkdir $STANDALONE_RESTORE && cp -f $JBOSS_HOME/standalone/configuration/standalone.xml $STANDALONE_RESTORE/standalone.xml" on container "wildfly" [47ms]

Maybe we could instead display something shorter like below, to have a consistent and decluttered output:

$ odo dev
  __
 /  \__     Developing using the "my-java-wildfly" Devfile
 \__/  \    Namespace: default
 /  \__/    odo version: v3.6.0
 \__/

↪ Running on the cluster in Dev mode
 •  Waiting for Kubernetes resources  ...
 ✓  Added storage m2-repository to component
 ⚠  Pod is Pending
 ✓  Pod is Running
 ✓  Syncing files into the container [96ms]
 ✓  Executing post-start command in container (command: copy-galleon) [835ms]
 ✓  Executing post-start command in container (command: provision-server) [8s]
 ✓  Executing post-start command in container (command: store-config) [52ms]
 ✓  Building your application in container (command: compile) [54s]
 ✓  Building your application in container (command: copy-artifact) [57ms]
 •  Executing the application (command: run)  ...
 -  Forwarding from 127.0.0.1:20001 -> 8080

 -  Forwarding from 127.0.0.1:20002 -> 16686

Any logs, error output, etc?

@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. area/dev Issues or PRs related to `odo dev` labels Feb 6, 2023
@rm3l rm3l added the area/UX Issues or PRs related to User Experience label Feb 6, 2023
@rm3l rm3l added this to odo Project Feb 6, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Feb 6, 2023
@rm3l rm3l self-assigned this Feb 6, 2023
@github-project-automation github-project-automation bot moved this to Done ✅ in odo Project Feb 7, 2023
@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Feb 7, 2023
@rm3l rm3l added this to the v3.7.0 🚀 milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev Issues or PRs related to `odo dev` area/UX Issues or PRs related to User Experience kind/bug Categorizes issue or PR as related to a bug.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant