Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognise devfile.yml and .devfile.yml as Devfiles #7060

Closed
datho7561 opened this issue Aug 29, 2023 · 2 comments · Fixed by #7130
Closed

Recognise devfile.yml and .devfile.yml as Devfiles #7060

datho7561 opened this issue Aug 29, 2023 · 2 comments · Fixed by #7130
Assignees
@rm3l
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/bug Categorizes issue or PR as related to a bug. priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Milestone
v3.16.0 🚀

Comments

@datho7561
Copy link

/kind bug

What versions of software are you using?

Operating System:
Fedora Linux 38

Output of odo version:

odo v3.14.0 (471928fea)

Server: https://api.crc.testing:6443
Kubernetes: v1.26.6+73ac561
Podman Client: 4.6.1

How did you run odo exactly?

  1. Clone https://github.com/eclipse/lemminx.
  2. Add the recommended Devfile, which was the Maven one.
  3. Rename the Devfile to devfile.yml
  4. odo dev

Actual behavior

odo starts initializing a new component in interactive mode

Expected behavior

Dev mode starts, using devfile.yml as the Devfile.

Any logs, error output, etc?

See redhat-developer/vscode-openshift-tools#3124
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Aug 29, 2023
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 29, 2023
@rm3l
Copy link
Member

rm3l commented Aug 30, 2023 •
edited
Loading

/status blocked

Blocked on devfile/api#1035, to clarify the acceptable filenames for devfile.
devfile/api#1035 (comment) suggested supporting .yaml only, based on the YAML spec FAQ.
Also related to devfile/api#744.
We'll need to confirm the decision on this..

@rm3l rm3l added area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) and removed needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. labels Aug 30, 2023
@rm3l rm3l mentioned this issue Sep 6, 2023
Open
@rm3l rm3l mentioned this issue Oct 24, 2023
Merged
3 tasks
@rm3l rm3l self-assigned this Oct 24, 2023
@rm3l rm3l added this to the v3.16.0 🚀 milestone Oct 24, 2023
@rm3l rm3l added the priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). label Oct 24, 2023
@rm3l rm3l moved this to In Progress 🚧 in odo Project Oct 24, 2023
@rm3l rm3l added priority/Medium Nice to have issue. Getting it done before priority changes would be great. and removed priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). labels Oct 27, 2023
@rm3l
Copy link
Member

rm3l commented Nov 2, 2023

/remove-status blocked

Unblocked now that devfile/api#1265 and devfile/api#744 have been fixed on the Devfile parser library side.
The changes in the Devfile library have been pulled in #7130.

@rm3l rm3l removed the status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) label Nov 2, 2023
@rm3l rm3l closed this as completed in #7130 Dec 1, 2023
@github-project-automation github-project-automation bot moved this from In Progress 🚧 to Done ✅ in odo Project Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rm3l rm3l

Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/bug Categorizes issue or PR as related to a bug. priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
odo Project
Archived in project
Milestone
v3.16.0 🚀
Development

Successfully merging a pull request may close this issue.

Recognize devfile.yml and .devfile.yml as Devfiles rm3l/odo
2 participants
@rm3l @datho7561