Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Java (codelens, hover) support in new a language server #215

Closed
angelozerr opened this issue Feb 7, 2020 · 1 comment
Closed

Move Java (codelens, hover) support in new a language server #215

angelozerr opened this issue Feb 7, 2020 · 1 comment
Assignees
Labels
debt invalid This doesn't seem right java-file quarkus-ls Quarkus Language Server Issue

Comments

@angelozerr
Copy link
Contributor

Today MicroProfile LS manages properties and java files both. It means that all client capability are shared between those 2 language. For instance, the format support is available for properties files but not for java files.

It causes this issue redhat-developer/vscode-quarkus#166

The Java support are done for CodeLens and Hover and doesn't use the MicroProfileProjectInfo, it means properties and java support shares anything, so we could move the java support in an another language server.

@angelozerr angelozerr self-assigned this Feb 20, 2020
@angelozerr angelozerr added this to the v0.0.6 milestone Feb 20, 2020
@angelozerr angelozerr added debt java-file quarkus-ls Quarkus Language Server Issue labels Feb 20, 2020
@fbricon fbricon removed this from the v0.0.6 milestone Feb 20, 2020
@angelozerr angelozerr added the invalid This doesn't seem right label Jul 16, 2020
@angelozerr
Copy link
Contributor Author

I close this issue because:

It causes this issue redhat-developer/vscode-quarkus#166 -

It was fixed

The Java support are done for CodeLens and Hover and doesn't use the MicroProfileProjectInfo, it means properties and java support shares anything, so we could move the java support in an another language server.

In Java files context we use application.properties from target, classes (and not sources) to provide in hover, code lens URL values which could be replaced by maven process, which is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt invalid This doesn't seem right java-file quarkus-ls Quarkus Language Server Issue
Projects
None yet
Development

No branches or pull requests

2 participants