Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

[E2E] Remove workspace on --bail not working for 7.1.0 #1599

Closed
Katka92 opened this issue Sep 5, 2019 · 4 comments
Closed

[E2E] Remove workspace on --bail not working for 7.1.0 #1599

Katka92 opened this issue Sep 5, 2019 · 4 comments

Comments

@Katka92
Copy link
Collaborator

Katka92 commented Sep 5, 2019

The --bail option should stop running the tests but still should stop and remove a workspace. That is not working as expected in 7.1.0. Fix that or remove --bail option before releasing.
Related to fixing tests for 7.1.0 #1575

@Katka92
Copy link
Collaborator Author

Katka92 commented Sep 11, 2019

According to the failed tests on prod-preview [1] it may be useful to DON'T run tests in --bail mode. The IDE in this particular tests was not started in 2 minutes, but started when test was waiting for a project. So we can see that all other tested components behaves correctly. If the --bail was set, we would have no idea if other components work correctly or not.
The "problem" is that if all other tests would fail (e.g. IDE is not loaded at all) we will have a huge report - screenshots of each failed tests etc. But IMHO it is still better to run tests without --bail.

[1]
Screenshot from 2019-09-11 12-44-14

@ibuziuk
Copy link
Member

ibuziuk commented Nov 8, 2019

@Katka92 is it still actual?

@Katka92
Copy link
Collaborator Author

Katka92 commented Nov 11, 2019

Yes, we still have some issues with --bail mode so we are not using it.

@Katka92
Copy link
Collaborator Author

Katka92 commented Dec 20, 2019

We are running without --bail till today and I think this is very valuable. We will not switch to --bail option so there is no need to investigate and fix this issue. Closing.

@Katka92 Katka92 closed this as completed Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants