Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 'Organize Imports' to be a CodeAction #513

Closed
mjbvz opened this issue Apr 18, 2018 · 2 comments
Closed

Move 'Organize Imports' to be a CodeAction #513

mjbvz opened this issue Apr 18, 2018 · 2 comments

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Apr 18, 2018

Hi, I'm on the vs code team. We recently introduced a more standardized way to implement Organize Imports with code actions (microsoft/vscode#47845). Using code actions instead of commands allows vs code to provide a more standard and consistent experience across languages. We are also using the new code action based implementation to power new UI like the Source Action context menu

screen shot 2018-04-18 at 11 59 22 am

Our JavaScript and TypeScript organize imports feature has already been migrated from a command to a code action: microsoft/vscode#46647 I suggest that the Java extension do the same so that the developer experinace is more consistent and to prevent conflicts with other extensions. This is currently blocked by microsoft/language-server-protocol#389

@fbricon
Copy link
Collaborator

fbricon commented Nov 14, 2018

Now that eclipse-jdtls/eclipse.jdt.ls#796 was merged, this should be doable.
@mjbvz do you know if it's possible to bind keys to a code action?

@fbricon
Copy link
Collaborator

fbricon commented Nov 21, 2018

The Organize imports command is no longer available directly at the root of the context menu, via the Source actions... menu:

new-organize-imports

The Shift+Alt+o shortcut is still working as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants