Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent rejected Promise during tag autoclose call #117

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

fbricon
Copy link
Collaborator

@fbricon fbricon commented Mar 20, 2019

Fixes rejected promise not handled within 1 second: TypeError: Cannot read property 'snippet' of null
extensionHostProcess.js:706
stack trace: TypeError: Cannot read property 'snippet' of null
extensionHostProcess.js:706
at tagProvider.then.result (/path/to/vscode-xml/out/src/tagClosing.js:59:35)

@fbricon fbricon added this to the 0.5.0 milestone Mar 20, 2019
Signed-off-by: Fred Bricon <fbricon@gmail.com>
@NikolasKomonen NikolasKomonen merged commit 6978f4f into redhat-developer:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants