Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect XML document encoding #759

Open
rgrunber opened this issue Aug 11, 2022 · 2 comments
Open

Respect XML document encoding #759

rgrunber opened this issue Aug 11, 2022 · 2 comments
Labels
bug Something isn't working upstream

Comments

@rgrunber
Copy link
Member

An XML document can have a document encoding :

<?xml version="1.0" encoding="UTF-8"?>

We should detect (entirely on client-side) the type of encoding and set it appropriately. VS Code currently doesn't handle this, so maybe we can support it on our end for now.

@rgrunber rgrunber added the bug Something isn't working label Aug 11, 2022
@ds1709
Copy link

ds1709 commented Aug 23, 2022

I agree. It's very annoying to reopen non UTF-8 xml file every time. Encodimg must be readen from xml file header.

@angelozerr
Copy link
Contributor

angelozerr commented Aug 24, 2022

I fear that vscode doesn't provide an API to update encoding according to this issue microsoft/vscode#824

vscode editorconfig extension cannot support charset because it is blocked by this API which doesn't exists editorconfig/editorconfig-vscode#35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream
Projects
None yet
Development

No branches or pull requests

3 participants