Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message for download error #763

Closed
mwisnicki opened this issue Aug 16, 2022 · 4 comments · Fixed by eclipse-lemminx/lemminx#1282
Closed

Improve error message for download error #763

mwisnicki opened this issue Aug 16, 2022 · 4 comments · Fixed by eclipse-lemminx/lemminx#1282
Assignees
@JessicaJHee
Milestone
0.22.0

Comments

@mwisnicki
Copy link

mwisnicki commented Aug 16, 2022 •
edited
Loading

I'm experiencing the issue similar to the one described in #134.

The error message Error while downloading 'foo.xsd' to 'C:\...' xml(DownloadProblem)

This message is entirely inadequate. Please change it to describe actual problem.
@angelozerr
Copy link
Contributor

If you activate the trace you should see the détail of the error.

What is your suggestion to improve the erŕor message?

@mwisnicki
Copy link
Author

The underlying error such as connection refused or relevant HTTP error should be surfaced to the UI in default configuration.

@JessicaJHee JessicaJHee self-assigned this Aug 18, 2022
@JessicaJHee JessicaJHee mentioned this issue Aug 18, 2022
Merged
@angelozerr
Copy link
Contributor

@mwisnicki see screenshot at eclipse-lemminx/lemminx#1282 (comment)

@mwisnicki
Copy link
Author

Looks great, thank you!

@angelozerr angelozerr added this to the 0.22.0 milestone Aug 26, 2022
@angelozerr angelozerr changed the title Inadequate error message for download error Improve error message for download error Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JessicaJHee JessicaJHee

Labels
None yet
Projects
None yet
Milestone
0.22.0
Development

Successfully merging a pull request may close this issue.

Improve download error message with detailed cause JessicaJHee/lemminx
3 participants
@mwisnicki @angelozerr @JessicaJHee