Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a custom image instead of the default image in WTO v 1.3.0 #123

Open
szemmour-rh opened this issue Jun 15, 2022 · 2 comments
Open

use a custom image instead of the default image in WTO v 1.3.0 #123

szemmour-rh opened this issue Jun 15, 2022 · 2 comments

Comments

@szemmour-rh
Copy link

szemmour-rh commented Jun 15, 2022

Describe the bug

In the version 1.3.0 i was not able to change the default image used by the web terminal operator

Expected Behavior

the new image set in DevWorkspaceTemplates [web-terminal-tooling] should be used by the terminal

Current Behavior

the old default image still used even after changing the DevWorkspaceTemplates [web-terminal-tooling] yaml

Steps to Reproduce

What steps can be done to reproduce

  1. Edit the DevWorkspaceTemplate named web-terminal-tooling in the openshift-operators namespace to set a new image for all users
  2. set web-terminal.redhat.com/unmanaged-state: true to make the change last

OpenShift Version:
4.8.35

@evanshortiss
Copy link

evanshortiss commented Jul 21, 2022

@szemmour-rh, maybe you already found a solution, but I wanted to share a solution.

I ran into this same problem, and found that it was because I didn't delete the current Pods that were running. Running this command, and then starting a new web terminal session worked for me:

oc delete pod -l 'controller.devfile.io/devworkspace_id' -n $YOUR_NAMESPACE

Edit: OpenShift version: 4.10.18, Web Terminal Operator 1.5.0, DevWorkspace Operator 0.14.1

@amisevsk
Copy link
Contributor

@evanshortiss is correct here, though you don't technically need to delete the pods -- any event related to the terminal will trigger the Operator to update the pod with the intended image. Deleting the pod does this, but so does adding an annotation to the pod/deployment/DevWorkspace.

This is occurring because the operator is event-driven -- if a terminal is running no objects are triggering events, the operator will not look at it and apply the updates from the DevWorkspaceTemplate. Without intervention, eventually the terminal you're using will shut down (idle -- default is 15 minutes), and when restarted will use the new image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants