Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CLIENT-SETINFO to support suffixes #185

Closed
chayim opened this issue Sep 13, 2023 · 1 comment
Closed

Update CLIENT-SETINFO to support suffixes #185

chayim opened this issue Sep 13, 2023 · 1 comment

Comments

@chayim
Copy link
Contributor

chayim commented Sep 13, 2023

CLIENT SETINFO should be extended to support community members inserting their own suffixes, for Redis usage.

  1. Clients should by default set-lib during connect with their name and version.
  2. Clients should allow users to not send this
  3. We should allow a user do send a suffix to the LIB-NAME portion - this allows us to learn about how things are used.
  4. Our clients continue to send their version upstream for LIB-VER

Strings should have the client name, and an optional suffix. They should be formatted ClientName(). For example:

  1. If you're NRedisStack - LIB-NAME: NRedisStack(StackExchange.Redis-v2.6.8;.NET-6.2.18) LIB-VERSION: 0.9.1
  2. If you're a project using NRedisStack (say SemtanticKernel): LIB-NAME (NRedisStack(SemanticKernel-v0.1.7;.NET-6.2.18) LIB-VERSION: 0.9.1

Considerations:

  1. Users should not send brackets, or braces, and we should error accordingly.
  2. We should replace spaces a user sends with hyphens
@shacharPash
Copy link
Contributor

Fixed in #180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chayim @shacharPash