StackExchange.Redis.IDatabase mock requires more setup now

[dmytrostruk]

NRedisStack Version: 0.10.0 or higher

Description:
Hi!
As soon as I update version of NRedisStack to 0.10.0 or higher, my unit tests with IDatabase mock are failing.

Previously, it was possible to mock IDatabase easier with:
mockDatabase.Setup(x => x.ExecuteAsync(...)).ReturnsAsync(...);

Now, it requires to mock not only ExecuteAsync method, but also:

• IDatabase.Multiplexer
• IConnectionMultiplexer.GetServer(...)
• IConnectionMultiplexer.GetEndPoints()
• IServer.Version.

I believe this is because of this line:

NRedisStack/src/NRedisStack/Auxiliary.cs

Line 75 in 954992e

var compareVersions = db.Multiplexer.GetServer(db.Multiplexer.GetEndPoints()[0]).Version.CompareTo(new Version(7, 1, 242));

It was added in this PR:
https://github.com/redis/NRedisStack/pull/180/files#diff-325a736b58343c97ea736c8f94320677e56eb9eaa2f6b8152ca732e41f8fd197R76

If this is desired implementation, maybe it worth to mention this change as breaking one, so users will know that additional mock setup needs to be added, so it will be possible to test classes that have NRedisStack as dependency.

Thank you!

[shacharPash]

Hi @dmytrostruk , thanks for the detailed issue!
I am checking if it is possible to solve it somehow so that you can do mocking as before without additional setup.
I will update.

[shacharPash]

@dmytrostruk Can you send me a simple example of a failed test? I want to see if I can fix it

[dmytrostruk]

Hi @shacharPash , sorry for late response, I didn't have a chance to check it until now.

It appeared that with new NRedisStack version 0.11.0, the only additional setup to mock IDatabase for index creation is the following:

var mockBatch = new Mock<IBatch>();
mockDatabase.Setup(x => x.CreateBatch(It.IsAny<object>())).Returns(mockBatch.Object);

In this case I believe this issue can be closed now. Thank you!