Update .circleci and refactor code

Author: nmammadli

.circleci/config.yml

@@ -927,7 +927,7 @@ workflows:
       - e2e-tests:
           name: E2ETest
           build: docker
-          parallelism: 1
+          parallelism: 4
           requires:
             - Build docker image
   # Workflow for feature, bugfix, main branches
@@ -973,7 +973,7 @@ workflows:
       - e2e-tests:
           name: E2ETest
           build: docker
-          parallelism: 1
+          parallelism: 4
           requires:
             - Build docker image
       # Approve to build
@@ -1061,7 +1061,7 @@ workflows:
       - e2e-tests:
           name: E2ETest
           build: docker
-          parallelism: 1
+          parallelism: 4
           requires:
             - Build docker image
 
@@ -1223,7 +1223,7 @@ workflows:
       # e2e web tests on docker image build
       - e2e-tests:
           name: E2ETest - Nightly
-          parallelism: 1
+          parallelism: 4
           build: docker
           report: true
           requires:

tests/e2e/common-actions/workbench-actions.ts

@@ -10,26 +10,7 @@ export class WorkbenchActions {
     async verifyClientListColumnsAreVisible(): Promise<void> {
         await t.expect(workbenchPage.clientListTableHeaderCellId.visible).ok('id column is not visible');
         await t.expect(workbenchPage.clientListTableHeaderCellAddr.visible).ok('addr column is not visible');
-        await t.expect(workbenchPage.clientListTableHeaderCellLAddr.visible).ok('laddr column is not visible');
-        await t.expect(workbenchPage.clientListTableHeaderCellFd.visible).ok('fd column is not visible');
         await t.expect(workbenchPage.clientListTableHeaderCellName.visible).ok('name column is not visible');
-        await t.expect(workbenchPage.clientListTableHeaderCellAge.visible).ok('age column is not visible');
-        await t.expect(workbenchPage.clientListTableHeaderCellIdle.visible).ok('idle column is not visible');
-        await t.expect(workbenchPage.clientListTableHeaderCellFlags.visible).ok('flags column is not visible');
-        await t.expect(workbenchPage.clientListTableHeaderCellDb.visible).ok('db column is not visible');
-        await t.expect(workbenchPage.clientListTableHeaderCellSub.visible).ok('sub column is not visible');
-        await t.expect(workbenchPage.clientListTableHeaderCellPSub.visible).ok('psub column is not visible');
-        await t.expect(workbenchPage.clientListTableHeaderCellMulti.visible).ok('multi column is not visible');
-        await t.expect(workbenchPage.clientListTableHeaderCellQBuf.visible).ok('qbuf column is not visible');
-        await t.expect(workbenchPage.clientListTableHeaderCellQBufFree.visible).ok('qbuf-free column is not visible');
-        await t.expect(workbenchPage.clientListTableHeaderCellQBufArgvMem.visible).ok('argv-mem column is not visible');
-        await t.expect(workbenchPage.clientListTableHeaderCellObl.visible).ok('obl column is not visible');
-        await t.expect(workbenchPage.clientListTableHeaderCellOll.visible).ok('oll column is not visible');
-        await t.expect(workbenchPage.clientListTableHeaderCellOmem.visible).ok('omem column is not visible');
-        await t.expect(workbenchPage.clientListTableHeaderCellTotMem.visible).ok('tot-mem column is not visible');
-        await t.expect(workbenchPage.clientListTableHeaderCellEvents.visible).ok('events column is not visible');
-        await t.expect(workbenchPage.clientListTableHeaderCellCmd.visible).ok('cmd column is not visible');
         await t.expect(workbenchPage.clientListTableHeaderCellUser.visible).ok('user column is not visible');
-        await t.expect(workbenchPage.clientListTableHeaderCellRedir.visible).ok('redir column is not visible');
     }
 }

tests/e2e/pageObjects/workbench-page.ts

@@ -143,28 +143,8 @@ export class WorkbenchPage {
     typeSelectedClientsList = Selector('[data-testid=view-type-selected-Plugin-client-list__clients-list]');
     clientListTableHeaderCellId = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_id_/);
     clientListTableHeaderCellAddr = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_addr_/);
-    clientListTableHeaderCellLAddr = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_laddr_/);
-    clientListTableHeaderCellFd = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_fd_/);
     clientListTableHeaderCellName = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_name_/);
-    clientListTableHeaderCellAge = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_age_/);
-    clientListTableHeaderCellIdle = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_idle_/);
-    clientListTableHeaderCellFlags = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_flags_/);
-    clientListTableHeaderCellDb = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_db/);
-    clientListTableHeaderCellSub = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_sub_/);
-    clientListTableHeaderCellPSub = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_psub_/);
-    clientListTableHeaderCellMulti = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_multi_/);
-    clientListTableHeaderCellQBuf = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_qbuf_/);
-    clientListTableHeaderCellQBufFree = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_qbuf-free_/);
-    clientListTableHeaderCellQBufArgvMem = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_argv-mem_/);
-    clientListTableHeaderCellObl = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_obl_/);
-    clientListTableHeaderCellOll = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_oll_/);
-    clientListTableHeaderCellOmem = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_omem_/);
-    clientListTableHeaderCellTotMem = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_tot-mem_/);
-    clientListTableHeaderCellEvents = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_events_/);
-    clientListTableHeaderCellCmd = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_cmd_/);
     clientListTableHeaderCellUser = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_user_/);
-    clientListTableHeaderCellRedir = Selector('[data-test-subj]').withAttribute('data-test-subj', /^tableHeaderCell_redir_/);
-
     /**
      * Get card container by command
      * @param command The command

tests/e2e/tests/regression/workbench/client-list-plugin.e2e.ts

@@ -1,16 +1,17 @@
 import { acceptLicenseTermsAndAddDatabaseApi } from '../../../helpers/database';
-import { WorkbenchPage } from '../../../pageObjects/workbench-page';
-import { MyRedisDatabasePage } from '../../../pageObjects';
+import { WorkbenchPage, MyRedisDatabasePage } from '../../../pageObjects';
 import {
     commonUrl,
     ossStandaloneRedisearch
 } from '../../../helpers/conf';
 import { env, rte } from '../../../helpers/constants';
 import { deleteStandaloneDatabaseApi } from '../../../helpers/api/api-database';
 import { Common } from '../../../helpers/common';
+import {WorkbenchActions} from '../../../common-actions/workbench-actions';
 
 const myRedisDatabasePage = new MyRedisDatabasePage();
 const workbenchPage = new WorkbenchPage();
+const workBenchActions = new WorkbenchActions();
 const common = new Common();
 
 const indexName = common.generateWord(5);
@@ -117,3 +118,20 @@ test('Big output in workbench is visible in virtualized table', async t => {
     // Verify that all commands scrolled
     await t.expect(lastExpectedItem.visible).ok('Final execution time message not displayed');
 });
+
+test.before(async t => {
+    await acceptLicenseTermsAndAddDatabaseApi(ossStandaloneRedisearch, ossStandaloneRedisearch.databaseName);
+    // Add index and data
+    await t.click(myRedisDatabasePage.workbenchButton);
+}).after(async t => {
+    await t.switchToMainWindow();
+    await deleteStandaloneDatabaseApi(ossStandaloneRedisearch);
+})('verify client list plugin shows table', async t => {
+    const command = 'CLIENT LIST';
+    // Send command in workbench to view client list
+    await workbenchPage.sendCommandInWorkbench(command);
+    await t.expect(workbenchPage.typeSelectedClientsList.visible).ok('client list view button is not visible');
+    await t.switchToIframe(workbenchPage.iframe);
+    // Verify that I can see the client List visualization available for all users.
+    await workBenchActions.verifyClientListColumnsAreVisible();
+});