fix: panic on nil error in handoffWorkerManager closeConnFromRequest

Author: ccoVeille

internal/maintnotifications/logs/log_messages.go

@@ -295,11 +295,10 @@ func RemovingConnectionFromPool(connID uint64, reason error) string {
 	})
 }
 
-func NoPoolProvidedCannotRemove(connID uint64, reason error) string {
-	message := fmt.Sprintf("conn[%d] %s due to: %v", connID, NoPoolProvidedMessageCannotRemoveMessage, reason)
+func NoPoolProvidedCannotRemove(connID uint64) string {
+	message := fmt.Sprintf("conn[%d] %s", connID, NoPoolProvidedMessageCannotRemoveMessage)
 	return appendJSONIfDebug(message, map[string]interface{}{
 		"connID": connID,
-		"reason": reason.Error(),
 	})
 }
 

maintnotifications/handoff_worker.go

@@ -468,7 +468,7 @@ func (hwm *handoffWorkerManager) closeConnFromRequest(ctx context.Context, reque
 		if err != nil {
 			hwm.logger().Errorf(ctx, "redis: failed to close connection: %v", err)
 		}
-		hwm.logger().Warnf(ctx, logs.NoPoolProvidedCannotRemove(conn.GetID(), err))
+		hwm.logger().Warnf(ctx, logs.NoPoolProvidedCannotRemove(conn.GetID()))
 	}
 }