add a comment

cxljs · cxljs · commit 944b067e146b · 2025-05-15T21:06:43.000+08:00
diff --git a/ring.go b/ring.go
@@ -349,6 +349,8 @@ func (c *ringSharding) newRingShards(
 	return
 }
 
+// Warning: External exposure of `c.shards.list` may cause data races.
+// So keep internal or implement deep copy if exposed.
 func (c *ringSharding) List() []*ringShard {
 	c.mu.RLock()
 	defer c.mu.RUnlock()

Original file line number	Diff line number	Diff line change
`@@ -349,6 +349,8 @@ func (c *ringSharding) newRingShards(`
`349`	`349`	`return`
`350`	`350`	`}`
`351`	`351`
	`352`	+// Warning: External exposure of `c.shards.list` may cause data races.
	`353`	`+// So keep internal or implement deep copy if exposed.`
`352`	`354`	`func (c ringSharding) List() []ringShard {`
`353`	`355`	`c.mu.RLock()`
`354`	`356`	`defer c.mu.RUnlock()`