Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: split commands for cluster mode #811

Closed
Eywek opened this issue Mar 8, 2019 · 8 comments
Closed

proposal: split commands for cluster mode #811

Eywek opened this issue Mar 8, 2019 · 8 comments

Comments

@Eywek
Copy link

Eywek commented Mar 8, 2019

Hello,

At my job, we want to use Redis Cluster in our production environment (for scaling purpose) but we've hit some limitations with ioredis. Indeed, we're using multi and mget commands with multiple keys (not in the same slot ofc), so we're wondering if ioredis can't do some command splitting (like https://github.com/eleme/corvus#commands for example) to send the right command to the right node.

We're not using corvus to avoid deploying a new service and because it don't support streams commands or pubsub.

Thanks

@luin
Copy link
Collaborator

luin commented Mar 11, 2019

I'm wondering why do you use multi in the cluster setup when the commands inside it belong to different slots? ioredis will distribute commands to the correct node as long as pipeline & multi are not used.

@Eywek
Copy link
Author

Eywek commented Mar 11, 2019

We were using multi before the requirement of using Redis Cluster, and sometimes we send a large amount of commands to the redis instance so multi is useful.

So, if I use a command like mget with multiple keys (not in the same slot), ioredis will distribute commands to the correct node for each key?

@luin
Copy link
Collaborator

luin commented Mar 11, 2019

@Eywek Aha, I got the point. Indeed the commands with keys belonging to different slots will not work (e.g. mget) with Redis.Cluster. We may have another class for that feature to avoid breaking backward compatibility.

@cocobiz
Copy link

cocobiz commented Apr 16, 2019

@luin Hi master, what's the road map about this feature? has any schedules?

@stale
Copy link

stale bot commented May 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 7 days if no further activity occurs, but feel free to re-open a closed issue if needed.

@stale stale bot added the wontfix label May 16, 2019
@luin
Copy link
Collaborator

luin commented May 16, 2019

@cocobiz Pull request is welcome currently.

@stale stale bot removed the wontfix label May 16, 2019
@stale
Copy link

stale bot commented Jun 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 7 days if no further activity occurs, but feel free to re-open a closed issue if needed.

@dineshS-dentsu
Copy link

How to overide RedisCache if it fails to connect to the server ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants