Skip to content

Commit 4097258

Browse files
committed
fix #1674 - remove isolationPoolOptions when creating isolated connection
1 parent c650d86 commit 4097258

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

lib/client/index.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,9 @@ export default class RedisClient<M extends RedisModules, S extends RedisScripts>
147147
this.#queue = this.#initiateQueue();
148148
this.#isolationPool = createPool({
149149
create: async () => {
150-
const duplicate = this.duplicate();
150+
const duplicate = this.duplicate({
151+
isolationPoolOptions: undefined
152+
});
151153
await duplicate.connect();
152154
return duplicate;
153155
},
@@ -269,8 +271,11 @@ export default class RedisClient<M extends RedisModules, S extends RedisScripts>
269271
};
270272
}
271273

272-
duplicate(): RedisClientType<M, S> {
273-
return new (Object.getPrototypeOf(this).constructor)(this.#options);
274+
duplicate(overrides?: Partial<RedisClientOptions<M, S>>): RedisClientType<M, S> {
275+
return new (Object.getPrototypeOf(this).constructor)({
276+
...this.#options,
277+
...overrides
278+
});
274279
}
275280

276281
async connect(): Promise<void> {

lib/cluster/index.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,11 @@ export default class RedisCluster<M extends RedisModules = {}, S extends RedisSc
6161
this.#Multi = RedisClusterMultiCommand.extend(options);
6262
}
6363

64-
duplicate<M extends RedisModules, S extends RedisScripts>(): RedisClusterType<M, S> {
65-
return new (Object.getPrototypeOf(this).constructor)();
64+
duplicate(overrides?: Partial<RedisClusterOptions<M, S>>): RedisClusterType<M, S> {
65+
return new (Object.getPrototypeOf(this).constructor)({
66+
...this.#options,
67+
...overrides
68+
});
6669
}
6770

6871
async connect(): Promise<void> {

0 commit comments

Comments
 (0)