Add type hints for set commands (#1918)

* add type hint for set commands

* switch to List

Author: dvora-h

redis/commands/core.py

@@ -2393,23 +2393,23 @@ class SetCommands:
     see: https://redis.io/topics/data-types#sets
     """
 
-    def sadd(self, name, *values):
+    def sadd(self, name: str, *values: List) -> int:
         """
         Add ``value(s)`` to set ``name``
 
         For more information check https://redis.io/commands/sadd
         """
         return self.execute_command("SADD", name, *values)
 
-    def scard(self, name):
+    def scard(self, name: str) -> int:
         """
         Return the number of elements in set ``name``
 
         For more information check https://redis.io/commands/scard
         """
         return self.execute_command("SCARD", name)
 
-    def sdiff(self, keys, *args):
+    def sdiff(self, keys: List, *args: List) -> List:
         """
         Return the difference of sets specified by ``keys``
 
@@ -2418,7 +2418,7 @@ def sdiff(self, keys, *args):
         args = list_or_args(keys, args)
         return self.execute_command("SDIFF", *args)
 
-    def sdiffstore(self, dest, keys, *args):
+    def sdiffstore(self, dest: str, keys: List, *args: List) -> int:
         """
         Store the difference of sets specified by ``keys`` into a new
         set named ``dest``.  Returns the number of keys in the new set.
@@ -2428,7 +2428,7 @@ def sdiffstore(self, dest, keys, *args):
         args = list_or_args(keys, args)
         return self.execute_command("SDIFFSTORE", dest, *args)
 
-    def sinter(self, keys, *args):
+    def sinter(self, keys: List, *args: List) -> List:
         """
         Return the intersection of sets specified by ``keys``
 
@@ -2450,7 +2450,7 @@ def sintercard(self, numkeys: int, keys: List[str], limit: int = 0) -> int:
         args = [numkeys, *keys, "LIMIT", limit]
         return self.execute_command("SINTERCARD", *args)
 
-    def sinterstore(self, dest, keys, *args):
+    def sinterstore(self, dest: str, keys: List, *args: List) -> int:
         """
         Store the intersection of sets specified by ``keys`` into a new
         set named ``dest``.  Returns the number of keys in the new set.
@@ -2460,23 +2460,23 @@ def sinterstore(self, dest, keys, *args):
         args = list_or_args(keys, args)
         return self.execute_command("SINTERSTORE", dest, *args)
 
-    def sismember(self, name, value):
+    def sismember(self, name: str, value: str) -> bool:
         """
         Return a boolean indicating if ``value`` is a member of set ``name``
 
         For more information check https://redis.io/commands/sismember
         """
         return self.execute_command("SISMEMBER", name, value)
 
-    def smembers(self, name):
+    def smembers(self, name: str) -> List:
         """
         Return all members of the set ``name``
 
         For more information check https://redis.io/commands/smembers
         """
         return self.execute_command("SMEMBERS", name)
 
-    def smismember(self, name, values, *args):
+    def smismember(self, name: str, values: List, *args: List) -> List[bool]:
         """
         Return whether each value in ``values`` is a member of the set ``name``
         as a list of ``bool`` in the order of ``values``
@@ -2486,15 +2486,15 @@ def smismember(self, name, values, *args):
         args = list_or_args(values, args)
         return self.execute_command("SMISMEMBER", name, *args)
 
-    def smove(self, src, dst, value):
+    def smove(self, src: str, dst: str, value: str) -> bool:
         """
         Move ``value`` from set ``src`` to set ``dst`` atomically
 
         For more information check https://redis.io/commands/smove
         """
         return self.execute_command("SMOVE", src, dst, value)
 
-    def spop(self, name, count=None):
+    def spop(self, name: str, count: Optional[int] = None) -> Union[str, List, None]:
         """
         Remove and return a random member of set ``name``
 
@@ -2503,7 +2503,11 @@ def spop(self, name, count=None):
         args = (count is not None) and [count] or []
         return self.execute_command("SPOP", name, *args)
 
-    def srandmember(self, name, number=None):
+    def srandmember(
+        self,
+        name: str,
+        number: Optional[int] = None,
+    ) -> Union[str, List, None]:
         """
         If ``number`` is None, returns a random member of set ``name``.
 
@@ -2516,15 +2520,15 @@ def srandmember(self, name, number=None):
         args = (number is not None) and [number] or []
         return self.execute_command("SRANDMEMBER", name, *args)
 
-    def srem(self, name, *values):
+    def srem(self, name: str, *values: List) -> int:
         """
         Remove ``values`` from set ``name``
 
         For more information check https://redis.io/commands/srem
         """
         return self.execute_command("SREM", name, *values)
 
-    def sunion(self, keys, *args):
+    def sunion(self, keys: List, *args: List) -> List:
         """
         Return the union of sets specified by ``keys``
 
@@ -2533,7 +2537,7 @@ def sunion(self, keys, *args):
         args = list_or_args(keys, args)
         return self.execute_command("SUNION", *args)
 
-    def sunionstore(self, dest, keys, *args):
+    def sunionstore(self, dest: str, keys: List, *args: List) -> int:
         """
         Store the union of sets specified by ``keys`` into a new
         set named ``dest``.  Returns the number of keys in the new set.