Fix issue with pack_commands returning an empty byte sequence

redis · Oct 19, 2022 · c9dfad3 · c9dfad3
1 parent 12f95de
commit c9dfad3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/redis/asyncio/connection.py b/redis/asyncio/connection.py
@@ -975,7 +975,8 @@ def pack_commands(self, commands: Iterable[Iterable[EncodableT]]) -> List[bytes]
                     or chunklen > buffer_cutoff
                     or isinstance(chunk, memoryview)
                 ):
-                    output.append(SYM_EMPTY.join(pieces))
+                    if pieces:
+                        output.append(SYM_EMPTY.join(pieces))
                     buffer_length = 0
                     pieces = []
 

diff --git a/redis/connection.py b/redis/connection.py
@@ -875,7 +875,8 @@ def pack_commands(self, commands):
                     or chunklen > buffer_cutoff
                     or isinstance(chunk, memoryview)
                 ):
-                    output.append(SYM_EMPTY.join(pieces))
+                    if pieces:
+                        output.append(SYM_EMPTY.join(pieces))
                     buffer_length = 0
                     pieces = []