Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add zmscore #1435

Closed
bionicles opened this issue Dec 18, 2020 · 2 comments
Closed

Please add zmscore #1435

bionicles opened this issue Dec 18, 2020 · 2 comments

Comments

@bionicles
Copy link

Version: 3.5.3

Platform: Python 3.8

Description:
Dear Redis-Py Maintainers,

I love your work and use it in multiple big projects for coronavirus and algotrading stocks.

Recently I found a use for one of the new 6.2 commands called ZMSCORE and request we add it:

Here's a minimal test case:

from redis import Redis
def test_zmscore():
    r = Redis()
    r.zadd("hall_of_fame", {"alice": 1.0, "bob": 2.0})
    scores = r.zmscore("hall_of_fame", "alice", "bob")
    return scores

if __name__ == "__main__":
    scores = test_zmscore()
    assert scores == [1.0, 2.0]

Here's the current output of the failing test case:

AttributeError: 'Redis' object has no attribute 'zmscore'

I'd like to add this myself but unfortunately I'm new to the codebase.

What is the most efficient way to add new commands?

Happy holidays,
Bion

@jiekun
Copy link
Contributor

jiekun commented Dec 21, 2020

Hello.
Thanks for pointing it out. I try to add support to this command and others new in 6.2 step by step.
But I assume @andymccurdy will tag a new release AFTER redis 6.2 stable build is out (which may take a long time).

@chayim
Copy link
Contributor

chayim commented Sep 1, 2021

Available in the latest master, and will be in the upcoming release. Closing.

@chayim chayim closed this as completed Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants