Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock.acquire argument blocking_timeout is not respected #498

Closed
grantcox opened this issue Jun 19, 2014 · 2 comments
Closed

Lock.acquire argument blocking_timeout is not respected #498

grantcox opened this issue Jun 19, 2014 · 2 comments

Comments

@grantcox
Copy link

The Lock.acquire() method accepts a blocking_timeout argument, but actually only self.blocking_timeout is used for setting the timeout limit. As such this argument has no effect.

https://github.com/andymccurdy/redis-py/blob/1acc67ac789b9a4cc8f480fbf328ae4c711e29a0/redis/lock.py#L108
@grantcox grantcox mentioned this issue Jun 19, 2014
Merged
@grantcox
Copy link
Author

Fix in Pull Request #499

@andymccurdy
Copy link
Contributor

Merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andymccurdy @grantcox