Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentinel erroring out when connection lost #946

Closed
daveisfera opened this issue Jan 15, 2018 · 2 comments
Closed

Sentinel erroring out when connection lost #946

daveisfera opened this issue Jan 15, 2018 · 2 comments
Labels

Comments

@daveisfera
Copy link
Contributor

Here's the stacktrace:

  File "/usr/local/lib/python3.6/site-packages/redis/client.py", line 1932, in eval
    return self.execute_command('EVAL', script, numkeys, *keys_and_args)
  File "/usr/local/lib/python3.6/site-packages/redis/client.py", line 572, in execute_command
    connection.send_command(*args) 
  File "/usr/local/lib/python3.6/site-packages/redis/connection.py", line 563, in send_command
    self.send_packed_command(self.pack_command(*args))
  File "/usr/local/lib/python3.6/site-packages/redis/connection.py", line 538, in send_packed_command
    self.connect()
  File "/usr/local/lib/python3.6/site-packages/redis/sentinel.py", line 44, in connect
    self.connect_to(self.connection_pool.get_master_address())
  File "/usr/local/lib/python3.6/site-packages/redis/sentinel.py", line 106, in get_master_address
    self.disconnect()
  File "/usr/local/lib/python3.6/site-packages/redis/connection.py", line 920, in disconnect
    for connection in all_conns:   
RuntimeError: Set changed size during iteration
@rolette
Copy link

rolette commented Jan 25, 2018

It's one of the various issues from #732. I submitted a PR #784 to fix it, but no joy getting it merged. We've been running with the fix for over a year with no problems.

You'll also want to grab PR #847 to avoid scenarios where you get OSError 99 under load after the master moves.

@github-actions
Copy link
Contributor

This issue is marked stale. It will be closed in 30 days if it is not updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants