Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to write to tempdir on windows #34

Closed
imathews opened this issue Nov 27, 2023 · 2 comments
Closed

Unable to write to tempdir on windows #34

imathews opened this issue Nov 27, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@imathews
Copy link
Member

We're not using proper cross-platform filepaths; e.g.: https://github.com/redivis/redivis-python/blob/main/src/redivis/common/list_rows.py#L97

Probably just need to use a proper path library rather than string interpolation.
@imathews imathews added the bug Something isn't working label Nov 27, 2023
@jbiggsets jbiggsets mentioned this issue Jan 7, 2024
Merged
@jbiggsets
Copy link
Contributor

jbiggsets commented Jan 7, 2024 •
edited
Loading

Hello! I submitted a PR (#35) to hopefully address this issue. (I was trying to use the client on a Windows machine and ran into this same bug.)

@imathews
Copy link
Member Author

imathews commented Jan 9, 2024

Closed in #35, released in 0.12.5

@imathews imathews closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imathews @jbiggsets