Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove redundant harbor logLevel #182

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Conversation

j-zimnowoda
Copy link
Contributor

No description provided.

@j-zimnowoda j-zimnowoda requested a review from Morriz October 27, 2020 07:27
@@ -6,7 +6,8 @@
{{- $harborSecretName := ($harborDomain | replace "." "-") }}
{{- $notarySecretName := ($notaryDomain | replace "." "-") }}
{{- $externalUrl := printf "https://%s" $harborDomain }}
logLevel: debug
# logLevel - debug, info, warning, error or fatal
logLevel: info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make this configurable?

And thinking about this even more, why not make log_level global configuration in order to run every service in debug mode?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making global debug would make a noise and put a lot of pressure on the platform.
So far we did not expose any log level to the values.
Anyway it is worth to consider doing it. @Morriz what do you think ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martijncalker please define a task for that, as exposing debug flag should be done for all services in a consistent way.

@Morriz Morriz added the Task Scrum task label Oct 27, 2020
@Morriz
Copy link
Contributor

Morriz commented Oct 27, 2020

does this have a corresponding issue @j-zimnowoda ? Please link

@Morriz Morriz removed the Task Scrum task label Oct 27, 2020
@Morriz
Copy link
Contributor

Morriz commented Nov 4, 2020 via email

@Morriz Morriz merged commit 917a37d into master Nov 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix_harbor_loglevel branch November 5, 2020 12:45
Dunky13 pushed a commit that referenced this pull request May 27, 2021
Ani1357 pushed a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants