-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove redundant harbor logLevel #182
Conversation
0b8e4b4
to
b127d31
Compare
@@ -6,7 +6,8 @@ | |||
{{- $harborSecretName := ($harborDomain | replace "." "-") }} | |||
{{- $notarySecretName := ($notaryDomain | replace "." "-") }} | |||
{{- $externalUrl := printf "https://%s" $harborDomain }} | |||
logLevel: debug | |||
# logLevel - debug, info, warning, error or fatal | |||
logLevel: info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not make this configurable?
And thinking about this even more, why not make log_level global configuration in order to run every service in debug mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making global debug would make a noise and put a lot of pressure on the platform.
So far we did not expose any log level to the values
.
Anyway it is worth to consider doing it. @Morriz what do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martijncalker please define a task for that, as exposing debug flag should be done for all services in a consistent way.
does this have a corresponding issue @j-zimnowoda ? Please link |
I am against one-for-all debug flag. Use debug levels surgically in one solution only when devving or troubleshooting. I am actually against putting them in the values, but it helps to find them there. The danger is that we don’t put it back to normal
… On 4 Nov 2020, at 13:56, jeho ***@***.***> wrote:
@j-zimnowoda commented on this pull request.
In values/harbor/harbor.gotmpl:
> @@ -6,7 +6,8 @@
{{- $harborSecretName := ($harborDomain | replace "." "-") }}
{{- $notarySecretName := ($notaryDomain | replace "." "-") }}
{{- $externalUrl := printf "https://%s" $harborDomain }}
-logLevel: debug
+ # logLevel - debug, info, warning, error or fatal
+logLevel: info
@martijncalker please define a task for that, as exposing debug flag should be done for all services in a consistent way.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
No description provided.