Revert "Rubocop autocorrect unsafe offences"

This reverts commit 3db5af6.

Because our unit tests assert that

Author: PowerKiKi

.rubocop.yml

@@ -127,4 +127,8 @@ Rails/EnvironmentVariableAccess:
 
 # Hrack::Server requires the `initialize` method
 Style/RedundantInitialize:
-    Enabled: false
+  Enabled: false
+
+# Because our unit tests assert that
+Rails/RedundantPresenceValidationOnBelongsTo:
+  Enabled: false

app/models/github_comment.rb

@@ -6,5 +6,5 @@ class GithubComment < ActiveRecord::Base
 
   ## Validations
   validates :github_id,  presence: true
-  validates :journal_id, uniqueness: { scope: :github_id }
+  validates :journal_id, presence: true, uniqueness: { scope: :github_id }
 end

app/models/github_issue.rb

@@ -6,5 +6,5 @@ class GithubIssue < ActiveRecord::Base
 
   ## Validations
   validates :github_id, presence: true
-  validates :issue_id, uniqueness: { scope: :github_id }
+  validates :issue_id,  presence: true, uniqueness: { scope: :github_id }
 end

app/models/gitolite_public_key.rb

@@ -16,6 +16,7 @@ class GitolitePublicKey < ActiveRecord::Base
   has_many   :repository_deployment_credentials, dependent: :destroy
 
   ## Validations
+  validates :user_id,     presence: true
 
   validates :title,       presence: true, uniqueness: { case_sensitive: false, scope: :user_id },
                           length: { maximum: TITLE_LENGTH_LIMIT }, format: /\A[a-z0-9_\-]*\z/i

app/models/repository_deployment_credential.rb

@@ -15,10 +15,11 @@ class RepositoryDeploymentCredential < ActiveRecord::Base
   belongs_to :user
 
   ## Validations
-  validates :repository_id,
-            uniqueness: { scope: :gitolite_public_key_id }
+  validates :repository_id,          presence: true,
+                                     uniqueness: { scope: :gitolite_public_key_id }
 
-  validates :gitolite_public_key_id, exclusion: { in: [-1] }
+  validates :gitolite_public_key_id, presence: true, exclusion: { in: [-1] }
+  validates :user_id,                presence: true
   validates :perm,                   presence: true,
                                      inclusion: { in: VALID_PERMS }
 

app/models/repository_git_config_key.rb

@@ -10,6 +10,7 @@ class RepositoryGitConfigKey < ActiveRecord::Base
   belongs_to :repository
 
   ## Validations
+  validates :repository_id, presence: true
   validates :type,          presence: true, inclusion: { in: ['RepositoryGitConfigKey::GitConfig', 'RepositoryGitConfigKey::Option'] }
   validates :value,         presence: true
 

app/models/repository_git_extra.rb

@@ -25,7 +25,7 @@ class RepositoryGitExtra < ActiveRecord::Base
   belongs_to :repository
 
   ## Validations
-  validates :repository_id, uniqueness: true
+  validates :repository_id,       presence: true, uniqueness: true
   validates :default_branch,      presence: true
   validates :key,                 presence: true
   validates :notification_sender, format: { with: URI::MailTo::EMAIL_REGEXP, allow_blank: true }

app/models/repository_mirror.rb

@@ -15,6 +15,7 @@ class RepositoryMirror < ActiveRecord::Base
   belongs_to :repository
 
   ## Validations
+  validates :repository_id, presence: true
 
   ## Only allow SSH format
   ## ssh://git@redmine.example.org/project1/project2/project3/project4.git

app/models/repository_post_receive_url.rb

@@ -12,6 +12,7 @@ class RepositoryPostReceiveUrl < ActiveRecord::Base
   belongs_to :repository
 
   ## Validations
+  validates :repository_id, presence: true
 
   # Only allow HTTP(s) format
   validates :url, presence: true,

app/models/repository_protected_branche.rb

@@ -16,6 +16,7 @@ class RepositoryProtectedBranche < ActiveRecord::Base
   has_many   :members, through: :protected_branches_members, source: :principal
 
   ## Validations
+  validates :repository_id, presence: true
   validates :path,          presence: true, uniqueness: { case_sensitive: true, scope: %i[permissions repository_id] }
   validates :permissions,   presence: true, inclusion: { in: VALID_PERMS }