New elasticsearch_v8 do not retry anymore

[defgenx]

Hello Redpanda team.

It looks like that the new Elasticsearch output has removed the retry mechanism since this PR (#3160). Is that normal ? Can we re-add it ?

I also see that the he upsert logic changed to rely on upsert key instead of using doc_as_upsert as before. Why this change ? Now we have to duplicate in .doc and in .upsert to achieve the same behavior ?
I did some tests and it looks like something is not working as expected.
I'll dig and try to provide more information soon.

[defgenx]

Ok so I confirm in case of upsert we have to set both doc and upsert fields... Most of the time we want to doc_as_upsertso I think we should add this option. I can create a PR for this one.

[defgenx]

Just closing the issue and will open a PR if needed.