Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal overflow in tables #1050

Closed
weeco opened this issue Jan 31, 2024 · 5 comments
Closed

Horizontal overflow in tables #1050

weeco opened this issue Jan 31, 2024 · 5 comments
Assignees
Labels
bug Something isn't working frontend

Comments

@weeco
Copy link
Contributor

weeco commented Jan 31, 2024

Tables that contain columns with very long values the table is overflowing and exceeds the panel in which it is wrapped. The horizontal scroll does not work. We should ensure that all tables (e.g. topics, schemas, connectors, ...) can handle long values. Specifically topic names can be up to 254 chars, and for other dynamic values such as the connector or schema name we should assume a similar max length that we should support.

image

Looks ok after adding overflow setting in chrome inspect:

image

image

Originally posted by @jseparovic in #1032 (comment) , I added more context.

@ghost
Copy link

ghost commented Feb 2, 2024

A quick fix for this: it's OK to truncate the connector name here. A user's primary focus here is whether or not the connector is healthy or not. They can always click into it to see more information, including the full name.

Mo and I are looking into improving tables more holistically.

@jseparovic
Copy link

Can you make this a configurable setting? I’m not a fan of truncating the name. This is currently the only way I can find the connector I’m looking for. A filter at the top to search for a connector name would be useful too. Configurable columns too would be ideal, in my setup I would get rid of everything except connector name.

@weeco
Copy link
Contributor Author

weeco commented Feb 3, 2024

We should definetely add a quicksearch input for searching connectors. I'm surprised we do not already have one since we have community users running more than 1k connectors in their environment! (Issue for adding quicksearch: #1091)

Configurable columns should be possible too! For example on the "Topics > List messages" tab we have a cogwheel in the table header row where you can configure the table settings including what columns you want to see. We could do something similar for the connectors too!

@ghost
Copy link

ghost commented Mar 6, 2024

To update this, we decided in a Slack discussion and through some feedback from CS to allow long table names to wrap instead of truncating:

image

Then, on the individual pages, we will show the names with the following pattern:

image

The title will be Topic or Connector with the full name underneath, copyable.

We can keep the truncation in breadcrumbs.

@weeco
Copy link
Contributor Author

weeco commented Mar 6, 2024

Fixed via #1159

@weeco weeco closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

No branches or pull requests

3 participants