-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oversized allocation: 323584 bytes in compression::stream_zstd::do_compress
#15900
Comments
It may be worth switching the Kafka zstd impl to |
Should we even have an interface that is prone to large allocs? |
1MiB allocation from this in;
|
The interface itself just takes in a const reference to an iobuf and returns an iobuf; which shouldn't be too problematic. It's what happens internally to compress the iobuf that is causing the large allocation. Compressing the iobuf in smaller chunks like |
Sorry I was asking more: Should we fix the allocations internally to this interface or remove it? It seems like it should be removed and everything updated to use the async version to prevent large allocations and reactor stalls. |
Ah, makes sense. I'm in favor of removing it and switching to the async version to avoid reactor stalls. It would mean having to change the other supported compression formats to the async interface as well. I suppose this could be as simple as returning a ready future for the other formats. At least until reactor stalls are a problem for them. |
Artifact URL: https://ci-artifacts.dev.vectorized.cloud:443/redpanda/43325/018c92ec-cd51-4c73-84a2-900e0cd07649/vbuild/output/redpanda-0.0.0-20231222gitf1fbe6cd-amd64.tar.gz
Test details:
Backtrace:
The text was updated successfully, but these errors were encountered: