Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Failure (Expected to delete some chunk files during seq-cons, none deleted) in CloudStorageChunkReadTest. test_read_chunks #21376

Closed
dotnwat opened this issue Jul 13, 2024 · 3 comments · Fixed by #21427
Assignees
Labels
area/cloud-storage Shadow indexing subsystem ci-failure kind/bug Something isn't working

Comments

@dotnwat
Copy link
Member

dotnwat commented Jul 13, 2024

https://buildkite.com/redpanda/redpanda/builds/51463#0190aaf1-31cb-40ed-9878-f6c9bcd62031

Module: rptest.tests.cloud_storage_chunk_read_path_test
Class:  CloudStorageChunkReadTest
Method: test_read_chunks
AssertionError('Expected to delete some chunk files during seq-cons, none deleted')
Traceback (most recent call last):
  File "/opt/.ducktape-venv/lib/python3.10/site-packages/ducktape/tests/runner_client.py", line 184, in _do_run
    data = self.run_test()
  File "/opt/.ducktape-venv/lib/python3.10/site-packages/ducktape/tests/runner_client.py", line 276, in run_test
    return self.test_context.function(self.test)
  File "/root/tests/rptest/services/cluster.py", line 105, in wrapped
    r = f(self, *args, **kwargs)
  File "/root/tests/rptest/tests/cloud_storage_chunk_read_path_test.py", line 264, in test_read_chunks
    raise ex
  File "/root/tests/rptest/tests/cloud_storage_chunk_read_path_test.py", line 250, in test_read_chunks
    assert rm_chunks.deleted_chunks > 0, "Expected to delete some chunk files during seq-cons, none deleted"
AssertionError: Expected to delete some chunk files during seq-cons, none deleted

JIRA Link: CORE-5591

@abhijat
Copy link
Contributor

abhijat commented Jul 16, 2024

After a certain point during test run, all possible chunks have been hydrated IE the file handles are open. The underlying files get deleted but the file handles remain open, so no chunk files are deleted from that point onwards. Possible fixes could include:

  • adding a quiet period to allow chunk eviction before running the seq. consumer
  • making the check more fine grained, IE assert chunks deleted > 0 only if some chunks were ever present in the cache during consumer scope, eg by looking at download metric
  • making the check scope larger, IE assert some chunk is deleted during both the rand. consumer and seq. consumer run.

I opted for the last one in #21427 as the purpose behind deleting chunks was to test the re-materialization of chunks and the assertion in itself is not valuable, only the side effect of removing files is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cloud-storage Shadow indexing subsystem ci-failure kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants